Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockfile will warn periodically if waiting more than 5s #234

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

league
Copy link
Collaborator

@league league commented May 19, 2024

Fixes #232.

I think this is ready to go. There's a self-contained test program at the bottom of the file, it's easy to compile and test in isolation.

Is a cerr message good enough?

@league league added the feature label May 29, 2024
@league
Copy link
Collaborator Author

league commented May 29, 2024

I will add the PID check to this PR.

@jaycedowell
Copy link
Collaborator

Works for me on Ubuntu 20.04 and MacOS 12.7.

@jaycedowell
Copy link
Collaborator

I was about to merge this when I noticed that the self-hosted builds were hanging. Why's that happening?

@jaycedowell
Copy link
Collaborator

Self hosted is back.

@jaycedowell jaycedowell merged commit c7b89c0 into master Jul 15, 2024
9 of 11 checks passed
@jaycedowell jaycedowell deleted the lockfile-wait-notice branch July 15, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve debuggability in case of a stale LockFile
2 participants