ar71xx: Add separate device for Archer C7 v2 IL

[Nurdok]

In discussion in commit fa0096f, @NeoRaider said:

I had a quick look at the stock firmware images from the TP-Link IL website, and they don't use the same region coding mechanism as the US/EU images. Instead of setting the region, they set the TPLINK_HWREV to 0x494c0001. To properly support the IL version, a separate Device/... definition should be added.

I am attempting to add the device myself, but this is my first time working with this code base, so help and review are appreciated. Currently, when I run make menuconfig, I don't see the new device as an option. Can someone guide me on what else should be done?

[neocturne]

You probably only need to delete the tmp directory in your LEDE tree before running make menuconfig so the new board is found.

Also, you changed the wrong ID: The IL version uses TPLINK_HWID := 0xc7000002 as well, but you must set TPLINK_HWREV to 0x494c0001.

[Nurdok]

Alright! With your comment, I managed to successfully flash my Archer C7 v2 (twice), install LuCI and set up WiFi on 2.4Ghz. Thanks you so much for the help!

My problem now is that the ac / 5Ghz interface is not detected - not on startup and not when I do rm /etc/config/wireless && wifi detect > /etc/config/wireless.

kmod-ath10k is installed, but I get the following in dmesg:

[    9.865169] PCI: Enabling device 0000:01:00.0 (0000 -> 0002)
[    9.871071] ath10k_pci 0000:01:00.0: pci irq legacy oper_irq_mode 1 irq_mode 0 reset_mode 0
[   10.088301] ath10k_pci 0000:01:00.0: Direct firmware load for ath10k/pre-cal-pci-0000:01:00.0.bin failed with error -2
[   10.099184] ath10k_pci 0000:01:00.0: Falling back to user helper
[   10.178763] firmware ath10k!pre-cal-pci-0000:01:00.0.bin: firmware_loading_store: map pages failed
[   10.188093] ath10k_pci 0000:01:00.0: Direct firmware load for ath10k/cal-pci-0000:01:00.0.bin failed with error -2
[   10.198622] ath10k_pci 0000:01:00.0: Falling back to user helper
[   10.377896] firmware ath10k!cal-pci-0000:01:00.0.bin: firmware_loading_store: map pages failed
[   10.386876] ath10k_pci 0000:01:00.0: Direct firmware load for ath10k/QCA988X/hw2.0/firmware-5.bin failed with error -2
[   10.397757] ath10k_pci 0000:01:00.0: Falling back to user helper
[   10.568255] firmware ath10k!QCA988X!hw2.0!firmware-5.bin: firmware_loading_store: map pages failed
[   10.577526] ath10k_pci 0000:01:00.0: could not fetch firmware file 'ath10k/QCA988X/hw2.0/firmware-5.bin': -11
[   10.587652] ath10k_pci 0000:01:00.0: Direct firmware load for ath10k/QCA988X/hw2.0/firmware-4.bin failed with error -2
[   10.598513] ath10k_pci 0000:01:00.0: Falling back to user helper
[   10.748836] firmware ath10k!QCA988X!hw2.0!firmware-4.bin: firmware_loading_store: map pages failed
[   10.758097] ath10k_pci 0000:01:00.0: could not fetch firmware file 'ath10k/QCA988X/hw2.0/firmware-4.bin': -11
[   10.768229] ath10k_pci 0000:01:00.0: Direct firmware load for ath10k/QCA988X/hw2.0/firmware-3.bin failed with error -2
[   10.779089] ath10k_pci 0000:01:00.0: Falling back to user helper
[   10.933497] firmware ath10k!QCA988X!hw2.0!firmware-3.bin: firmware_loading_store: map pages failed
[   10.942755] ath10k_pci 0000:01:00.0: could not fetch firmware file 'ath10k/QCA988X/hw2.0/firmware-3.bin': -11
[   10.952889] ath10k_pci 0000:01:00.0: Direct firmware load for ath10k/QCA988X/hw2.0/firmware-2.bin failed with error -2
[   10.963748] ath10k_pci 0000:01:00.0: Falling back to user helper
[   11.136783] firmware ath10k!QCA988X!hw2.0!firmware-2.bin: firmware_loading_store: map pages failed
[   11.146046] ath10k_pci 0000:01:00.0: could not fetch firmware file 'ath10k/QCA988X/hw2.0/firmware-2.bin': -11
[   11.156129] ath10k_pci 0000:01:00.0: could not fetch firmware files (-11)
[   11.163011] ath10k_pci 0000:01:00.0: could not probe fw (-11)

Any pointers on what to try?

[neocturne]

You're missing the package ath10k-firmware-qca988x.

The tp-link.mk change looks good. Please switch the TPLINK_HWID and TPLINK_HWREV lines though, as the hardware ID is the top-level ID, and the hardware revision is the sub-ID.

Please also squash your commits into one and add a Signed-off-by line, so we can merge your commit.

[Nurdok]

@NeoRaider does this look okay?

[neocturne]

It seems you accidentially rebased unrelated patches (there are still 3 commits in this PR, 2 of them are unrelated). Just rebasing onto the LEDE master again should fix that (or use git rebase -i to remove the unrelated commits from the history).

The commit message is missing the "ar71xx: " prefix, and I'd recommend changing it to "ar71xx: build image for Archer C7 v2 IL". Apart from that, the commit is fine like this.

[Nurdok]

@NeoRaider Sorry for all the close / reopen / push noise - had some trouble rebasing.
In any case, I fixed the issues you mentioned,

[neocturne]

Thanks, merged!

[Nurdok]

Awesome! Thanks for all the help!