ipq806x: add RPM cc, idle states and minor stuff #494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Kubelun <be.dissent@gmail.com>
Signed-off-by: Pavel Kubelun <be.dissent@gmail.com>
|
Hi @dissent1 I apply your patch and firmware booting up corectly. Thanks |
|
looks good, let me know when its ready |
|
@heinzek could you please test if spi pins update fixes reboot issue and issue with saving settings during update? |
|
@dissent1 I tested Your commits and reboot issue still exist. Issue with saving settings work OK, but first boot after restart takes ~450 sec, after this wifi not starting. After reboot router boot in 30 sec and wifi work OK with saved settings. ps. Can You check why LED wan red ( gpio 26) not work? Thanks |
|
So now at least it saves settings? Have you tried the current commit? I had typo in previous version. Have you tried sysupgrading from version with this commit to version with this commit? Or from your version to version with this commit? |
|
@heinzek try this patch on top of this pull request dissent1@5eaef88 |
|
Regarding the reboot issue, could it be that you're are facing the spi flash chip reboot bug that is addressed with the commit "ramips: fix reboot hang with 32MB spi flash" in #464. If yes, could any of you give me a hint which flash chip is used for the Archer C2600 v1.0 and which one for the Archer C2600 v1.1. Might be possible that it is already fixed in later kernel versions and we just need to backport a patch. |
|
@mkresin v1.0 - s25fl256s1, v1.1 - mx25u25635f. |
|
I've updated the commit and also added "jedec,spi-nor" compatibility in accordance to the driver |
Well I don't see an initialisation problem here. It's just a hang of the SPI chip on shutdown/reboot. Properly because of missing workaround for a MX25(U/L)25635 quirk. For reference, the Newifi D1 has a MX25L25635. Seams to me the spi chips are near to identical and @heinzek should give the patch in #464 a try and reply at #464 if the issue for the Archer C2600 v1.1 is fixed as well. |
mkresin
requested changes
Nov 9, 2016
| @@ -124,7 +139,7 @@ | |||
| cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>; | |||
|
|
|||
| flash: m25p80@0 { | |||
| compatible = "s25fl256s1"; | |||
| compatible = "s25fl256s1", "mx25u25635f", "jedec,spi-nor"; | |||
There was a problem hiding this comment.
only compatible = "jedec,spi-nor"; here. Everything else is either unsupported or only available due to backward compatibility.
Check the comments of the source file for details: http://lxr.free-electrons.com/source/drivers/mtd/devices/m25p80.c?v=4.4#L246
| @@ -148,7 +194,7 @@ | |||
| cs-gpios = <&qcom_pinmux 20 0>; | |||
|
|
|||
| flash: m25p80@0 { | |||
| compatible = "s25fl512s"; | |||
| compatible = "s25fl512s", "jedec,spi-nor"; | |||
There was a problem hiding this comment.
only compatible = "jedec,spi-nor"; here for the same reasons explained above.
|
@heinzek do you really need pins 23 and 25 exported? According to c2600 gpl it's not for USB use. |
|
@dissent1 I compile firmware with Your latest patches and reboot still not work.
I check patch form #464 and this not work ( compile error). Try make other patch based on this: https://patchwork.ozlabs.org/patch/541391 and it work good. Reboot issue is fixed: |
The patch lede-project#179 for RPM has initially been made for apq806x board. It has been modified to support ipq806x instead of apq8064. Signed-off-by: Pavel Kubelun <be.dissent@gmail.com>
Signed-off-by: Pavel Kubelun <be.dissent@gmail.com>
Signed-off-by: Pavel Kubelun <be.dissent@gmail.com>
Fix pci pins drive-strength according to oem sources. Signed-off-by: Pavel Kubelun <be.dissent@gmail.com>
Netgear R7500v2 has 512MB of RAM with 2MB reserved block in the end of memory region. Signed-off-by: Pavel Kubelun <be.dissent@gmail.com>
Updating spi pins configuration in R7800 and C2600 DTs Adding more usb power pin export and gsbi6 in R7800 DT Updating and fixing leds Signed-off-by: Pavel Kubelun <be.dissent@gmail.com>
|
I've been doing some tests with RPM cc patch revisions, seems this only version doesn't return errors. @heinzek red wan is not assigned to anything now, the same for red wan on R7800. I'm not sure that you can assign red led on wan link up and white led on getting ip address or Internet accessibility while turning red led off. |
|
@dissent1 please don't add the spi patch. it is a submission of a different PR and should not be part of your PR. Have you considered to close this PR and open a Pull Request if you have something that is not work in progress. I mean what you are doing with the github PR feature isn't what it is made for. Usually you open a PR if your changes are ready to commit. But instead you are adding constantly new feature to your PR. It might be better to keep the changes just in your repository. |
|
@mkresin I'm sorry for that, I admit that it is not a good practice. At the time I submitted PR it was ready to be merged but then I came across some more stuff. I was not going to add the spi patch because there is discussion on it as I can see :) These changes are ready if it's OK. |
I know this, but I try to power on this led using command:
Nope. eth0 and eth1 is allways up because is connected to switch AR8337. i think You can use: and add to config-4.4: CONFIG_SWCONFIG_LEDS=y This working, but leds not blinking and you can not see what is the use of WAN / LAN. |
|
merged, Thanks ! |
|
@dissent1 Your watchdog backport causes build errors on ip806x. Because of the error, the snapshots are not updated since 16-Nov-2016. Would you please have a look at this! If you're backporting kernel stuff or add kernel patches, compile test with all kernel modules enabled: |
|
What's the exact error? I cannot repeat it. It builds fine with that option checked in my tree |
|
http://phase1.builds.lede-project.org/builders/ipq806x%2Fgeneric/builds/275/steps/kmods/logs/stdio drivers/hwmon/sch56xx-common.c:418:2: error: unknown field 'ref' specified in initializer |
|
Seems there are 3 patches missing, should I provide a new PR or add a commit into this one? |
|
19.11.2016 11:31, dissent1:
New PR please! this one is closed and no one will look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RPM Clock Controller, RPM message RAM and cpu idle states.
Please take into account, that 179 rpm patch is a modified version of the one that has been submitted upstream. The original patch is for apq8064 board only, so I modified it to work on ipq806x only.
Sooner or later this patch will go upstream and we'll have to make another patch that adds support for ipq806x in addition to apq8064 but not replacing it.
003 upstream patch has also been modified- cxo/pxo clocks are left at 25kHz/25kHz in contrary to upstream changes as it's not completely stable now and requires more testing.
Also replacing existing patch for WDT Barktime with set of patches from upstream.
@heinzek