! SleeperNotifier#notifyAfter would break if passed negative value.

ledestin · Nov 8, 2013 · 2c76521 · 2c76521
1 parent c3fc722
commit 2c76521
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/frugal_timeout.rb b/lib/frugal_timeout.rb
@@ -148,6 +148,7 @@ def latestDelay
     def notifyAfter sec
       synchronize {
 	sleep 0.01 until @thread.status == 'sleep'
+	sec = 0 if sec < 0
 	@latestDelay = sec
 	@thread.wakeup
       }

diff --git a/spec/frugal_timeout_spec.rb b/spec/frugal_timeout_spec.rb
@@ -187,6 +187,13 @@ def new_timeout_request_thread sec, res, resMutex
     (Time.now - start - 0.5).round(2).should <= 0.01
   end
 
+  it 'handles negative delay' do
+    FrugalTimeout::MonotonicTime.measure {
+      sleeper.notifyAfter -1
+      queue.shift
+    }.round(1).should == 0
+  end
+
   it 'sends notification one time only for multiple requests' do
     5.times { sleeper.notifyAfter 0.5 }
     sleeper.notifyAfter 0.4