Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min_volume for audio cut off range is 0 to 10, but effective range is 0 to 1 #898

Closed
bigredfrog opened this issue Apr 5, 2024 · 2 comments

Comments

@bigredfrog
Copy link
Contributor

Describe the bug
the slider range for the min audio cut off is 0 to 10 as per code in

https://github.com/LedFx/LedFx/blob/main/ledfx/effects/audio.py#L121

The actual max volume range from the audio chain is 0 to 1

Therefore anything over 1 is "no audio"

As much as changing the value in the line referenced is easy, we would need code to auto heal any configs out there that are > 1 otherwise they will crash out with out of range.

As much as no one should have such a setting as ledfx would not be working, it probably needs doing right

@bigredfrog
Copy link
Contributor Author

#953

@bigredfrog
Copy link
Contributor Author

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant