Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing a Report Command Edits the Expanded Form #325

Open
kevinjfoley opened this issue Jan 22, 2022 · 0 comments · May be fixed by #326
Open

Editing a Report Command Edits the Expanded Form #325

kevinjfoley opened this issue Jan 22, 2022 · 0 comments · May be fixed by #326

Comments

@kevinjfoley
Copy link
Contributor

When editing a command using ledger-report-edit-report, the user is presented with the ledger-report-format-specifiers already expanded. This means if they save the edit, the format specifier values will then be hard coded.

I intend to open a PR to store the un-expanded report command in ledger-report-cmd and wait until ledger-do-report to actual expand the command. I wanted to open this issue to document the problem.
kevinjfoley added a commit to kevinjfoley/ledger-mode that referenced this issue Jan 22, 2022
@kevinjfoley
[ledger-report] Delay report command expansion
0573def 
Delays the expansion of the report command until execution time.  This leaves
the command in `ledger-report-cmd' unexpanded, which prevents the expanded
version of the command from being edited / saved by the user.

Resolves ledger#325
@kevinjfoley kevinjfoley linked a pull request Jan 22, 2022 that will close this issue
Open
kevinjfoley added a commit to kevinjfoley/ledger-mode that referenced this issue Feb 4, 2022
@kevinjfoley
[ledger-report] Delay report command expansion
7746467 
Delays the expansion of the report command until execution time.  This leaves
the command in `ledger-report-cmd' unexpanded, which prevents the expanded
version of the command from being edited / saved by the user.

Resolves ledger#325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ledger-report] Delay report command expansion kevinjfoley/ledger-mode
1 participant
@kevinjfoley