copy cost from automatic transaction postings #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e2f64be. post->cost is actually of type optional, so the cast to bool iscorrect.
|
It is possible that copying the cost should go in post_t::copy_details instead of in xact_t::extend_xact. But it is not entirely clear to me what the copy_details method is supposed to do. It really begs the question, "which details?" Why does it not already copy things like cost, assigned_amount, account, etc.? Also, I do not really understand why copy_details is called from the copy constructor--that appears redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2268 by preserving the cost from automatic transactions and reflecting it in target transactions.