Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need permissions to add CI jobs #90

Closed
alerque opened this issue Oct 25, 2019 · 15 comments
Closed

Need permissions to add CI jobs #90

alerque opened this issue Oct 25, 2019 · 15 comments
Assignees

Comments

@alerque
Copy link
Member

alerque commented Oct 25, 2019

For some reason even with being listed as a member of the vim-hackers group inside this org (see #75 for backstory) I still don't have permission to work on repository settings. I would like to setup a CI workflow to lint the vimscript and require validation on changes before merging but am unable to do so.

@jwiegley could you either grant me access for this or signup for GitHub Actions and enable it on this repository? I have access to the beta and could enable it for any repository I have settings access to but that doesn't include this one.

I've actually setup the job spec already (see #89) modeled after what I've recently contributed the same feature on vim-pandoc, tagbar, firenvim, vim-sile, and others. It just needs the settings arranged properly.

@alerque
Copy link
Member Author

alerque commented Oct 25, 2019

@kljohann Does your status in the vim-ledger-hackers team let you grant me access to this repository's settings?

@alerque alerque assigned alerque, jwiegley and kljohann and unassigned alerque Oct 26, 2019
@kljohann
Copy link
Member

@alerque I could not figure out how, so I guess not. Maybe John can enable GitHub Actions for this repo?

@alerque
Copy link
Member Author

alerque commented Oct 26, 2019

Thanks for the response @kljohann. I guess the ball is in @jwiegley's court. Enabling Actions would be a start, but it is kind of a stop-gap. I'm going to try to setup proper testing for this plugin to include not just the lint job already configured and waiting, but also checking that commands and completions don't error out on a matrix including vim and nvim editors paired with ledger and hledger backends. That's going to require a couple phases of adding settings — in particular I need access to the PR requirements and branch protection settings to do this properly. Do you have any objection to my being added as a maintainer/owner/whatever it takes to manage those things on this repository?

@jwiegley
Copy link
Member

@kljohann You are now an admin for this repository, not just a maintainer.

I've signed up for GitHub Actions, but still don't know how to enable it for this repository, if @kljohann is unable to.

@alerque
Copy link
Member Author

alerque commented Oct 26, 2019

Thanks for the response @jwiegley. I'm not sure what exactly you changed, but are you sure it was on the right repository? And you hit "Apply"? 😉 I've been poking around and can't find a single thing different than before. The usual "settings" menu is still not offered to me — as if I was a collaborator but not an owner (to use personal repo terms, I'm unclear on what the org repos call this).

After you sign up for Actions and are approved, you should then have the option of signing up any orgs you own from the same signup page. Once the org is signed up then it should become available in the repo settings.

@alerque
Copy link
Member Author

alerque commented Oct 26, 2019

Here is what I'm seeing when trying to access this repository, notably missing "settings":

image

For comparison here is a comparison of what I expect to have show up, including the settings tab plus (after the org has signed up) some of the options that start to be available for Actions:

image

That gets things started, then it's a matter of running some jobs sucessfully, then we can start adding them as part of the PR workflow (so I'd be using the branches and integrations sections of settings too).

I've been poking around and I can't figure out what it was you even changed because nothing seems to be different from my view.

@jwiegley
Copy link
Member

This is what I see:
GitHub · Where software is built 2019-10-27 12-04-16

@jwiegley
Copy link
Member

I don't see anything that's repository-specific about the invitation...

@alerque
Copy link
Member Author

alerque commented Oct 28, 2019

@jwiegley under that select account drop down menu you should see the ledger org. Once the org is signed up each repo can (en|dis)able it in settings.

@jwiegley
Copy link
Member

Ok, should be good to go now, thanks for being patient with me!

@alerque
Copy link
Member Author

alerque commented Oct 30, 2019

Thanks @jwiegley. As evidenced by the new green check mark next to this project's name above, that does get the party started. Actions is not activated and running per the workflow I previously setup. That's a start, I'll keep iterating on the test suite.

That doesn't fully address this issue however because I still cannot access the settings for this repository. I would like to be able to administer the branch protection and required checks settings, and these will change as I add tests. Can we please look into setting the necessary permissions for that? Thanks.

@jwiegley
Copy link
Member

@alerque You're now a maintainer for this repo. Is that enough?

@alerque
Copy link
Member Author

alerque commented Nov 1, 2019

I figured it would be @jwlegley, but no I still cannot see branch protection rules which is where CI status check requirements should come up. I do have a "settings" link now which is new, but it is stripped down to just two things: "Options" (which only have a limited set of the usual options) and "Moderation". Missing are the "Branches" and "Integrations".

@jwiegley
Copy link
Member

jwiegley commented Nov 1, 2019

Ok, now you're a bloody admin! See if that helps. If not, I'll anoint you as one of the blessed ones, and then by ritual combat we will promote you into the Greater Pantheon, from whence you can even just merged vim and Emacs into One Great Editor.

@alerque
Copy link
Member Author

alerque commented Nov 2, 2019

That does help. Github could use a bit more granular controls! On the other hand this journey of discovery has let to the idea of merging vim and emacs — although surely rebase would be better than merge. Vim will be the base handling the heavy lifting obviously, emacs will be an alternate UI layer. I'll get right on that (and in the mean time be sure to use my lesser powers only for good).

@alerque alerque closed this as completed Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants