Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Genuine - Indentation error #52

Open
felipetdsa opened this issue Oct 18, 2018 · 1 comment
Open

Check Genuine - Indentation error #52

felipetdsa opened this issue Oct 18, 2018 · 1 comment

Comments

@felipetdsa
Copy link

When doing
$python -m ledgerblue.checkGenuine --targetId 0x31100003

Got the error:

Traceback (most recent call last):
File "/anaconda3/lib/python3.6/runpy.py", line 183, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
File "/anaconda3/lib/python3.6/runpy.py", line 153, in _get_module_details
code = loader.get_code(mod_name)
File "", line 781, in get_code
File "", line 741, in source_to_code
File "", line 219, in _call_with_frames_removed
File "/anaconda3/lib/python3.6/site-packages/ledgerblue/checkGenuine.py", line 110
return ret
^
TabError: inconsistent use of tabs and spaces in indentation

@DarthJahus
Copy link

There's a space before return ret at line 110. It should be replaced by a tab.

I'd also recommend to handle the case when given targetId doesn't finish with 2 or 3. Just in case.

DarthJahus added a commit to DarthJahus/blue-loader-python that referenced this issue Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants