Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylesheets are in the wrong order #1174

Closed
pbolger opened this issue Dec 29, 2015 · 0 comments
Closed

Stylesheets are in the wrong order #1174

pbolger opened this issue Dec 29, 2015 · 0 comments
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base.
Milestone

Comments

@pbolger
Copy link

pbolger commented Dec 29, 2015

Stylesheets are read top to bottom. dojo.css includes a css reset, which should come first in the list.

Current order
css/(user).css
global.css
claro/claro.css
dojo.css
expanding.css

Should be more like this:

global.css
expanding.css
dojo.css
claro.css
(user).css

Which would allow user overriding without having to resort to !important for every rule.

I would question allowing resource specific stylesheets to include global css too. dojo is aimed at specific elements and shouldn't be targetting elements like p or img.

@ehuelsmann ehuelsmann modified the milestone: 1.4.23 Jan 1, 2016
@ehuelsmann ehuelsmann added the bite-sized Deemed a good starting point for new contributors to learn about the code base. label Jan 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base.
Projects
None yet
Development

No branches or pull requests

2 participants