Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.4.13.1 - html templates contain attributes not supported in HTML 5 #1180

Closed
amr-gh opened this issue Dec 31, 2015 · 2 comments
Closed

1.4.13.1 - html templates contain attributes not supported in HTML 5 #1180

amr-gh opened this issue Dec 31, 2015 · 2 comments
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base. type:enhancement Proposed improvement, new feature, or extension -- not a defect
Milestone
1.8

Comments

@amr-gh
Copy link

amr-gh commented Dec 31, 2015

in 1.4.13.1
System -> HTML Templates
Contains HTML attributes like hr noshade that are not supported in HTML 5.
@ehuelsmann ehuelsmann modified the milestone: 1.4.23 Jan 1, 2016
@ehuelsmann ehuelsmann added the bite-sized Deemed a good starting point for new contributors to learn about the code base. label Jan 1, 2016
@ehuelsmann ehuelsmann modified the milestones: 1.4, 1.4.23 Jan 8, 2016
@einhverfr einhverfr modified the milestones: 1.4, 1.5 Jul 22, 2016
@ehuelsmann ehuelsmann added bite-sized Deemed a good starting point for new contributors to learn about the code base. type:enhancement Proposed improvement, new feature, or extension -- not a defect and removed bite-sized Deemed a good starting point for new contributors to learn about the code base. type:enhancement Proposed improvement, new feature, or extension -- not a defect Minor enhancement labels Dec 17, 2017
@ehuelsmann ehuelsmann modified the milestones: 1.5, 1.6 Mar 3, 2018
@ehuelsmann ehuelsmann modified the milestones: 1.6, 1.7 May 10, 2018
@ehuelsmann ehuelsmann modified the milestones: 1.7, 1.8 Jun 23, 2019
@ehuelsmann
Copy link
Member

This concerns the templates in templates/

@ehuelsmann
Copy link
Member

Upon further investigation: all templates correctly declare a DOCTYPE for XHTML 1.0 (with the exception of "letterhead", which is supposed to be included, so shouldn't declare one). I suppose this isn't an issue. We may want to check document validity against the currently declared doctype, but that's beyond the scope of this issue.

@snyk-bot snyk-bot mentioned this issue Apr 15, 2021
Open
@snyk-bot snyk-bot mentioned this issue Apr 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base. type:enhancement Proposed improvement, new feature, or extension -- not a defect
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@einhverfr @ehuelsmann @amr-gh