Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default length of Project Dropdown too short or missing #1195

Closed
sbts opened this issue Jan 3, 2016 · 7 comments
Closed

Default length of Project Dropdown too short or missing #1195

sbts opened this issue Jan 3, 2016 · 7 comments
Labels
type:enhancement Proposed improvement, new feature, or extension -- not a defect waiting-for-user Issue can't progress unless feedback from reporter is received
Milestone

Comments

@sbts
Copy link
Member

sbts commented Jan 3, 2016

Looking at this link on the demo for 1.4.22
https://demo.cloud.efficito.com/erp/1.4/login.pl?action=login&company=demo14
It can be seen that the "Project" Dropdown box is defaulting to auto width which is aesthetically unpleasing.
We should have a minimum width set for all controls.

screenshot from 2016-01-04 05 52 21

@ehuelsmann ehuelsmann modified the milestone: 1.4 Jan 5, 2016
@einhverfr einhverfr modified the milestones: 1.4, 1.4.27 Feb 14, 2016
@einhverfr einhverfr modified the milestones: 1.4.27, 1.4.28 Mar 18, 2016
@ehuelsmann ehuelsmann modified the milestones: 1.4.28, 1.4.29 May 3, 2016
@ehuelsmann ehuelsmann added the type:enhancement Proposed improvement, new feature, or extension -- not a defect label May 20, 2016
@ehuelsmann ehuelsmann modified the milestones: 1.4, 1.4.29 May 20, 2016
@ehuelsmann
Copy link
Member

all dropdowns are missing width declaration...

@einhverfr einhverfr modified the milestones: 1.4, 1.5 Jul 30, 2016
@einhverfr
Copy link
Member

how would we set the width without knowing the contents?

@ehuelsmann
Copy link
Member

Hmm. but once the admin created the projects, the contents is known, right?

OTOH, I'm also feeling for a simple "min-width" CSS declaration...

@ehuelsmann ehuelsmann modified the milestones: 1.5, 1.6 Mar 3, 2018
@ehuelsmann ehuelsmann modified the milestones: 1.6, 1.7 May 10, 2018
@ehuelsmann ehuelsmann modified the milestones: 1.7, 1.8 Jun 23, 2019
@ehuelsmann ehuelsmann modified the milestones: 1.8, 1.9, 1.10 May 17, 2020
@ehuelsmann
Copy link
Member

there are 2 possible solutions here: tag-specific style attributes for which we generate the content dynamically. I'm not sure that works really well with i18n though. The other is to dynamically select a class based on the maximum length of the content which is available from the user-defined style sheet.

@sbts
Copy link
Member Author

sbts commented Oct 3, 2020

While I agree that setting the width based on content length is preferable and our end goal.
In the immediate sense ( and it can be retained as a default for when there is no data yet) all fields should have a rational min-width defined.
The minimum should be something that fits with the purpose of the field, and visual layout intent.

@ehuelsmann
Copy link
Member

The minimum should be something that fits with the purpose of the field, and visual layout intent.

If I may ask, then why do you pick this detail? There's a lot of layout work to be done. Almost all of the filter pages are completely unstyled or if they are, still look crap. Why then pick on the drop-down?

@ehuelsmann ehuelsmann added the waiting-for-user Issue can't progress unless feedback from reporter is received label Oct 3, 2020
@no-response
Copy link

no-response bot commented Jan 1, 2021

Closing: more than 90 days without user response. Feel free to reopen with your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Proposed improvement, new feature, or extension -- not a defect waiting-for-user Issue can't progress unless feedback from reporter is received
Projects
None yet
Development

No branches or pull requests

3 participants