Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'selected item' indication to the main menu #1196

Closed
pbolger opened this issue Jan 3, 2016 · 3 comments
Closed

Add 'selected item' indication to the main menu #1196

pbolger opened this issue Jan 3, 2016 · 3 comments
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base. type:enhancement Proposed improvement, new feature, or extension -- not a defect
Milestone
1.8

Comments

@pbolger
Copy link

pbolger commented Jan 3, 2016

Normally this would be done by adding a class to the list item in the menu on page load.
Suggestion by ehuelsmann:
"make use of dojo's publish/subscribe model and allow the menu items to subscribe to page loading events with names"
@ehuelsmann ehuelsmann modified the milestone: 1.5 Jan 5, 2016
@ehuelsmann ehuelsmann added the bite-sized Deemed a good starting point for new contributors to learn about the code base. label May 19, 2016
@ehuelsmann ehuelsmann added the type:enhancement Proposed improvement, new feature, or extension -- not a defect label Jun 5, 2016
@einhverfr
Copy link
Member

major due to testing/build requirements

@einhverfr
Copy link
Member

This could be done in 1.5 using a class. For later versions the pubsub model is probably better but don't want to break things in a stable version.

@ehuelsmann ehuelsmann added bite-sized Deemed a good starting point for new contributors to learn about the code base. type:enhancement Proposed improvement, new feature, or extension -- not a defect and removed bite-sized Deemed a good starting point for new contributors to learn about the code base. type:enhancement Proposed improvement, new feature, or extension -- not a defect Minor enhancement labels Dec 17, 2017
@ehuelsmann ehuelsmann modified the milestones: 1.5, 1.6 Mar 3, 2018
@ehuelsmann ehuelsmann modified the milestones: 1.6, 1.7 May 10, 2018
@ehuelsmann ehuelsmann modified the milestones: 1.7, 1.8 Jun 23, 2019
@ehuelsmann
Copy link
Member

In 1.6, we switched to a Dojo Tree widget which has exactly this property. Closing as dealt with in 1.6.

@snyk-bot snyk-bot mentioned this issue Apr 15, 2021
Open
@snyk-bot snyk-bot mentioned this issue Apr 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base. type:enhancement Proposed improvement, new feature, or extension -- not a defect
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@pbolger @einhverfr @ehuelsmann