Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top of main menu crowded #1203

Closed
sbts opened this issue Jan 4, 2016 · 4 comments
Closed

Top of main menu crowded #1203

sbts opened this issue Jan 4, 2016 · 4 comments
Assignees
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base.
Milestone

Comments

@sbts
Copy link
Member

sbts commented Jan 4, 2016

The area under the logo, and above the menu contains some status info.
* add some white space above and below.
* center the text
* remove the bold attribute
* consider adding a dynamically updated session count after the username
eg: Logged in as user (6)
where the session count is the number of currently logged in sessions for that user.
It would be expected that a session would include all windows open in a single browser
so 10 open tabs or windows would count as 1 session.
A login from 2 different browsers would be 2 sessions (on the same or different machines)

@sbts sbts added the bite-sized Deemed a good starting point for new contributors to learn about the code base. label Jan 4, 2016
@sbts sbts added this to the 1.5 milestone Jan 4, 2016
@ehuelsmann
Copy link
Member

ehuelsmann commented May 25, 2016

What about this:

screenshot from 2016-05-25 10 28 06

?

Although maybe the slash should be changed for an 'at' sign these days?

@ehuelsmann
Copy link
Member

ehuelsmann commented May 25, 2016

Storing the HTML (with embedded CSS) required to do that here for a moment:

<div style="text-align: center"><a target="_blank" href="http://ledgersmb.org/">
        <img class="cornderlogo" src="images/ledgersmb_small.png" alt="LedgerSMB" height="50" width="100" border="1">
  </a><br>
<div id="version_info">1.4.26</div></div>
<div style="text-align: center; margin-top: 1em; margin-bottom: 1em;">
  <span id="login_info">ehuelsmann</span> / 
  <span id="company_info">efficito</span>
</div>

@sbts
Copy link
Member Author

sbts commented May 25, 2016

As discussed on IRC the proposed change looks good.
However the session count should be moved to a separate issue for future implementaion

@ehuelsmann ehuelsmann added the type:enhancement Proposed improvement, new feature, or extension -- not a defect label Jun 5, 2016
@einhverfr einhverfr modified the milestones: 1.6, 1.5 Aug 10, 2016
@sbts sbts self-assigned this Oct 21, 2016
@ehuelsmann ehuelsmann removed the type:enhancement Proposed improvement, new feature, or extension -- not a defect label Nov 22, 2016
@ehuelsmann
Copy link
Member

This has been resolved when we replaced the menu for 1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base.
Projects
None yet
Development

No branches or pull requests

3 participants