Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

Added a Hard Fork event which will enable transaction metadata in Bor #1064

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Added a Hard Fork event which will enable transaction metadata in Bor #1064

wants to merge 18 commits into from

Conversation

pratikspatil024
Copy link

Transaction metadata will help speed up parallel execution (Block-STM).
The block producer will calculate the dependency and put it in the Extra Field in the Block Header.

@pratikspatil024 pratikspatil024 marked this pull request as draft August 2, 2023 05:59
@pratikspatil024 pratikspatil024 marked this pull request as ready for review August 4, 2023 03:00
battlmonstr
battlmonstr suggested changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@battlmonstr battlmonstr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a new field that is never initialized, and a new function that is never called. I don't understand what's the idea here?
Please refer me to the client code.

@pratikspatil024
Copy link
Author

Hi @battlmonstr, I am working on Block-STM and I need this function to store transaction dependency (which Block-STM will use) in the Extra field in Bor's block header. This PR does a similar change in Bor.

Therefore I have created this PR. Once this is merged, I'll use this function in the erigon repo and will create a PR there.

For your reference, there is a similar PR.

Thank you.

@battlmonstr
Copy link
Collaborator

battlmonstr commented Aug 17, 2023 •
edited
Loading

@pratikspatil024 thanks for explaining. Could you create that erigon PR you plan to do and refer to this one? Whoever reviews the erigon's PR should review and merge both PRs at the same time (adjusting the erigonlib reference). For local development I recommend to add this to go.mod:

replace github.com/ledgerwatch/erigon-lib => ../erigon-lib

(assuming the erigon-lib is cloned to the parent directory of erigon)

this should untie you from having this PR merged first, before working on the erigon's PR

@pratikspatil024 pratikspatil024 mentioned this pull request Aug 18, 2023
Merged
@pratikspatil024
Copy link
Author

Thanks, @battlmonstr. Created the PR.

yperbasis and others added 15 commits August 18, 2023 13:41
@yperbasis @pratikspatil024
Fix blob transaction panic in txpool (ledgerwatch#1065)
9fae34d 
Fixes the following panic triggered by blob Hive tests:
```
[2c098836] panic: runtime error: index out of range [0] with length 0
[2c098836] 
[2c098836] goroutine 902 [running]:
[2c098836] github.com/ledgerwatch/erigon-lib/txpool.MainLoop.func1()
[2c098836] 	github.com/ledgerwatch/erigon-lib@v0.0.0-20230801100033-1b342f37741d/txpool/pool.go:1565 +0x100f
[2c098836] created by github.com/ledgerwatch/erigon-lib/txpool.MainLoop
[2c098836] 	github.com/ledgerwatch/erigon-lib@v0.0.0-20230801100033-1b342f37741d/txpool/pool.go:1492 +0x8c5
```
@racytech @pratikspatil024
init kzg ctx from file (trusted_setup.json) (ledgerwatch#1066)
f5920e2
@yperbasis @pratikspatil024
OverrideShanghaiTime -> OverrideCancunTime (ledgerwatch#1067)
d574daa
@Giulio2002 @pratikspatil024
Added memory diff to memory mutation (ledgerwatch#1068)
3e39df5
@Giulio2002 @pratikspatil024
save (ledgerwatch#1070)
629b4ee
@Giulio2002 @pratikspatil024
removed missingHash (ledgerwatch#1071)
ff0f0d7
@yperbasis @pratikspatil024
interfaces: Add parent_beacon_block_root (EIP-4788) (ledgerwatch#1069)
36f9c0b 
Pick up erigontech/interfaces#187
@AskAlexSharov @pratikspatil024
Recsplit: cancelable build (ledgerwatch#1073)
a48a2fc
@AskAlexSharov @pratikspatil024
pool: don't warn at Ctrl+C
474c26f
@AskAlexSharov @pratikspatil024
tmpdb: move to tmpdir (ledgerwatch#1074)
db4777d
@Giulio2002 @pratikspatil024
Gnosis fields for execution.proto (ledgerwatch#1072)
5ad4889
@Giulio2002 @pratikspatil024
added sentinel direct (ledgerwatch#1077)
b874d9d
@AskAlexSharov @pratikspatil024
up 'x' packages versions (ledgerwatch#1076)
ec2582b
@AskAlexSharov @pratikspatil024
log file unmap/close errors (ledgerwatch#1036)
dc1d96d
@AskAlexSharov @pratikspatil024
Update README.md (ledgerwatch#1079)
ae3da07
@yperbasis
Copy link
Collaborator

@pratikspatil024 Please rebase/merge the latest erigon-lib so that only your own changes are displayed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@battlmonstr battlmonstr battlmonstr requested changes

@manav2401 manav2401 manav2401 approved these changes

Assignees
No one assigned
Labels
polygon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pratikspatil024 @battlmonstr @yperbasis @manav2401 @racytech @Giulio2002 @AskAlexSharov