Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

Idempotent (*PendingPool) Remove #534

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Idempotent (*PendingPool) Remove #534

merged 1 commit into from
Jul 19, 2022

Conversation

yperbasis
Copy link
Collaborator

0 currentSubPool means that the transaction is already removed. (*SubPool) Remove already sets currentSubPool to 0.

Hopefully this should fix the following error observed on a Ropsten node:

panic: runtime error: index out of range [-1]

goroutine 3225 [running]:
github.com/ledgerwatch/erigon-lib/txpool.(*bestSlice).Swap(...)
    github.com/ledgerwatch/erigon-lib@v0.0.0-20220719040828-9ceeeac385ad/txpool/pool.go:2025
github.com/ledgerwatch/erigon-lib/txpool.(*bestSlice).UnsafeRemove(...)

Here is the full log:
alloc_logs_erigon.stderr_3.0.txt

@yperbasis yperbasis merged commit af5355e into main Jul 19, 2022
@yperbasis yperbasis deleted the txpool_remove branch July 19, 2022 14:05
@yperbasis yperbasis mentioned this pull request Jul 19, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AskAlexSharov AskAlexSharov Awaiting requested review from AskAlexSharov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yperbasis