Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Turbogeth imports compatible with go-ethereum #122

Closed
mandrigin opened this issue Oct 17, 2019 · 1 comment
Closed

Make Turbogeth imports compatible with go-ethereum #122

mandrigin opened this issue Oct 17, 2019 · 1 comment

Comments

@mandrigin
Copy link
Collaborator

When rebasing to a new version of geth, a lot of conflicts happen because of different import names.

When a new import added upstream, git gets confused. Resolving these merges is trivial, but annoying and can lead to occasionally importing actual unpatched go-ethereum module.
@mandrigin
Copy link
Collaborator Author

with go modules, this task will be harder and more error prone to do than to keep renaming imports like we do right now, closing.

@lucyzhang314 lucyzhang314 mentioned this issue Aug 10, 2021
Closed
battlmonstr pushed a commit that referenced this issue Sep 14, 2023
@AskAlexSharov
Pool v2: set 10K as default limit for sub-pool, check key existence b…
66c9c6f 
…efore delete (#122)
cffls pushed a commit to cffls/erigon that referenced this issue Feb 14, 2024
@V-Staykov
fixed the genesis and config for cardoan internal (ledgerwatch#122)
007321e
jyellick pushed a commit to bobanetwork/op-erigon that referenced this issue Feb 26, 2024
@ImTei
Merge pull request ledgerwatch#122 from testinprod-io/upstream-v2.52.5
50cd766 
Upstream v2.52.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mandrigin