Added body close on retry for downloader round trip #10008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fm8914
approved these changes
Apr 21, 2024
| @@ -183,6 +183,11 @@ func (r *requestHandler) RoundTrip(req *http.Request) (resp *http.Response, err | |||
| case http.StatusInternalServerError, http.StatusBadGateway: | |||
| r.downloader.stats.WebseedServerFails.Add(1) | |||
|
|
|||
| if resp.Body != nil { | |||
There was a problem hiding this comment.
maybe also add:
defer func() {
if err == nil && resp != nil && resp.Body != nil {
resp.Body.Close()
}
}
to close at panic?
There was a problem hiding this comment.
This is an intermediate function I'm not sure it should be catching panics - I think they should propagate up to the caller ?
There was a problem hiding this comment.
If need propagate - can propagate by panic(rec). i'm only about closing body.
There was a problem hiding this comment.
FYI: you also can take a look for inspiration https://github.com/hashicorp/go-retryablehttp/blob/main/client.go#L535
|
Plz add comment about: why this status codes are choosen, why no other retryable codes: https://stackoverflow.com/a/74627395 |
AskAlexSharov
approved these changes
Apr 23, 2024
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing body close method when webseed roundtrip is retried