stagedSync: Optimize prune old chunks #10019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
requested changes
Apr 23, 2024
eth/stagedsync/stage_log_index.go
Outdated
| if err := pruneLogKeyCollector.Collect(k, nil); err != nil { | ||
| return err | ||
| } | ||
| c.DeleteCurrent() |
There was a problem hiding this comment.
- err not checked
- plz use
tx.Delete(table, k). Because seems some version of mdbx has bug when same cursor used forforiteration andDeleteCurrent- we did workaround it by using 2 cursors ortx.Delete, tnx. I'm not sure which versions are affected - because not easy to reproduce.
There was a problem hiding this comment.
tx.DeleteCurrentpattern is used at many places in the code base. Are you also saying all of them need fixing too, then? Because the way i see it,DeleteCurrentcan only be used in a for loop like that.- What is the performance impact of using
tx.Deletehere, compared toDeleteCurrent?
There was a problem hiding this comment.
DeleteCurrent is not bad - use 1 cursor to iterate and in same time DeleteCurrent - bad in some mdbx versions.
No performance impact (of course it’s there - O(1) vs O(n log n), but mdbx’s methods itself are fast-enough, bottleneck is usually in “touching cold data”, but you touching it by loop anyway).
Don’t need modify other places.
There was a problem hiding this comment.
Okay, for now, using tx.Delete in its place
somnathb1
changed the title
taratorio
approved these changes
Apr 23, 2024
AskAlexSharov
approved these changes
Apr 24, 2024
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes prune point for log (+index)
kv.Logentries, delete in the initial looppruneToblock number in thePruneState- this will begin pruning from that point. Earlier thepruneFrompoint being passed in was buggy as it used some other assumption for this value