Suffix reorg #113
Merged
Suffix reorg #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common/dbutils/suffix_type.go
Outdated
| } | ||
| buf := bytes.NewBuffer(b) | ||
| h := SuffixHistory{} | ||
| err := rlp.Decode(buf, &h) |
There was a problem hiding this comment.
I would prefer not to use rlp package, if possible. It is very inefficient both in terms of allocations and cpu usage. That is why I used hand-written encoding before
b00ris
commented
Oct 16, 2019
ethdb/database.go
Outdated
| @@ -86,26 +86,40 @@ func (db *BoltDatabase) Put(bucket, key []byte, value []byte) error { | |||
| } | |||
|
|
|||
| // Put puts the given key / value to the queue | |||
| func (db *BoltDatabase) PutS(hBucket, key, value []byte, timestamp uint64) error { | |||
| func (db *BoltDatabase) PutS(hBucket, key, value []byte, timestamp uint64, noHistory bool) error { | |||
There was a problem hiding this comment.
Comment. Invert noHistory
There was a problem hiding this comment.
I think we can defer this change to: #119
| //fmt.Printf("PutS bucket %x key %x value %x timestamp %d\n", bucket, key, value, timestamp) | ||
| composite, _ := dbutils.CompositeKeySuffix(key, timestamp) | ||
| suffixM, ok := m.suffixkeys[timestamp] | ||
| if !ok { | ||
| suffixM = make(map[string][][]byte) | ||
| suffixM = make(map[string][]dbutils.Change) | ||
| m.suffixkeys[timestamp] = suffixM |
| res, err := getStat(db) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } |
| ErrAccountsInHistory: 0, | ||
| ErrDecodedAccountsInHistory: 0, | ||
| NumOfChangesInAccountsHistory: 0, | ||
| AccountSuffixRecordsByTimestamp: map[uint64]uint32{ |
There was a problem hiding this comment.
add comments for test
JekaMas
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #97