Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linters are not stable #150

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Linters are not stable #150

merged 1 commit into from
Nov 6, 2019

Conversation

JekaMas
Copy link
Contributor

@JekaMas JekaMas commented Nov 6, 2019

  • Update circleci golang version
  • Update golangci-lint version

@b00ris
Copy link
Contributor

b00ris commented Nov 6, 2019

We have an issue in the linter binary:
golang/go#31008
golangci/golangci-lint#484

Example:

$ go vet ./core/ 
$ ./build/bin/golangci-lint run --disable-all --enable vet ./core/ 
WARN [runner] Can't process result by autogenerated_exclude processor: can't filter issue result.Issue{FromLinter:"govet", Text:"nilness: nil dereference in index operation", Pos:token.Position{Filename:"", Offset:0, Line:0, Column:0}, LineRange:(*result.Range)(nil), HunkPos:0, SourceLines:[]string(nil), Replacement:(*result.Replacement)(nil)}: no file path for issue 
WARN [runner] Can't process result by nolint processor: can't filter issue result.Issue{FromLinter:"govet", Text:"nilness: nil dereference in index operation", Pos:token.Position{Filename:"", Offset:0, Line:0, Column:0}, LineRange:(*result.Range)(nil), HunkPos:0, SourceLines:[]string(nil), Replacement:(*result.Replacement)(nil)}: no file path for issue 
WARN [runner/source_code] Failed to get line 0 for file : failed to get file  lines cache: can't get file  bytes from cache: can't read file : open : no such file or directory 
:0: nilness: nil dereference in index operation (govet)

@b00ris b00ris merged commit c9e1cb8 into master Nov 6, 2019
@AlexeyAkhunov AlexeyAkhunov deleted the linters-are-not-stable-#149 branch December 2, 2019 08:42
BlinkyStitt pushed a commit to llamanodes/erigon that referenced this pull request Jul 6, 2023
battlmonstr pushed a commit that referenced this pull request Sep 14, 2023
jyellick pushed a commit to bobanetwork/op-erigon that referenced this pull request Apr 4, 2024
…-priority-fee

Add minimum suggested priority gas price
taratorio pushed a commit that referenced this pull request Jul 23, 2024
* Updated mainnet.toml

* Updated mainnet.toml

---------

Co-authored-by: Michele Modolo <nospam@nospam.nospam>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants