Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix canExtendCanonical when some headers are downloaded #4709

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Fix canExtendCanonical when some headers are downloaded #4709

merged 3 commits into from
Jul 14, 2022

Conversation

yperbasis
Copy link
Collaborator

@yperbasis yperbasis commented Jul 13, 2022 •
edited
Loading

When some ancestors are downloaded for a new PoS header, the check

canExtendCanonical := header.ParentHash == currentHeadHash

in verifyAndSaveNewPoSHeader() was too restrictive because the freshly downloaded ancestors might be not canonized yet.

@yperbasis yperbasis added the proof-of-stake "The Merge" related commits label Jul 13, 2022
@yperbasis yperbasis marked this pull request as draft July 13, 2022 20:06
@yperbasis yperbasis marked this pull request as ready for review July 14, 2022 08:45
@yperbasis yperbasis merged commit af661a9 into devel Jul 14, 2022
@yperbasis yperbasis deleted the merge_stuff_r branch July 14, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002

Assignees
No one assigned
Labels
proof-of-stake "The Merge" related commits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yperbasis