Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized payload cleanup #4772

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Optimized payload cleanup #4772

merged 1 commit into from
Jul 20, 2022

Conversation

Giulio2002
Copy link
Collaborator

No description provided.

mandrigin
mandrigin approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@mandrigin mandrigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, but if we can somehow reduce duplication with regular unwinds, that would be even better. Could be a follow up PR

@Giulio2002 Giulio2002 merged commit 73b028a into devel Jul 20, 2022
@Giulio2002 Giulio2002 deleted the accumulator_unwind branch July 20, 2022 16:16
@Giulio2002
Copy link
Collaborator Author

Yes, that is possible, but it would be less optimized, also note that this PR drastically reduce database hits and makes the whole code base more stable, i am not sure how to nitpick it but i can try

@mandrigin
Copy link
Collaborator

@Giulio2002 yeah, that is why I am not asking you to change it in place, but I feel, it could be done in a more generic way somehow, otherwise it is very similar to a regular unwind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandrigin mandrigin mandrigin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Giulio2002 @mandrigin