fixed passing of raw byte slices to tx processing #4782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
requested changes
Jul 22, 2022
| @@ -14,8 +14,8 @@ const MaxBodiesInRequest = 1024 | |||
|
|
|||
| type Delivery struct { | |||
| peerID [64]byte | |||
| txs [][][]byte | |||
| uncles [][]*types.Header | |||
| txs *[][][]byte | |||
There was a problem hiding this comment.
[] - it’t a pointer-type (already no copy). Why this PR works?
There was a problem hiding this comment.
my guess is that helps GC to understand when txs become useless: in it's origin tx become useless right after sending through channel and on the other side of channel pointer to tx becomes useless when for is over. At this point gc could safely mark and then sweep them.
since [][]byte copied to txs are slices allocated by Raw and GC didn't know when they become useless -> Raw leaked.
|
core.ExecuteBlockEphemerally It’s part of StageExecution |
AskAlexSharov
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #4688
Inuse space at goerli during stage 6/16
pprof data before patch were similar to #4688 (comment)
Another interesting thing: recently were updated
core.ExecuteBlockEphemerally. Is that correct that it's called during syncing?