Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed timeout on CL #4836

Merged
merged 4 commits into from
Jul 27, 2022
Merged

fixed timeout on CL #4836

merged 4 commits into from
Jul 27, 2022

Conversation

Giulio2002
Copy link
Collaborator

No description provided.

@yperbasis
Copy link
Collaborator

What was the timeout problem? To me this change looks weird and negating PR #4797.

@yperbasis yperbasis added the proof-of-stake "The Merge" related commits label Jul 26, 2022
@mandrigin
Copy link
Collaborator

@yperbasis in our case latest devel basically times out on everything engine-related.

@yperbasis
Copy link
Collaborator

@yperbasis in our case latest devel basically times out on everything engine-related.

Still, I don't understand the logic of the change. What's the cause of the timeout? Perhaps we should revert PR #4797 instead.

Copy link
Collaborator

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@yperbasis yperbasis merged commit 039b661 into devel Jul 27, 2022
@yperbasis yperbasis deleted the fix-timeout-lighthouse branch July 27, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proof-of-stake "The Merge" related commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants