Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinalizeTx after engine.Initialize #5783

Merged
merged 1 commit into from
Oct 18, 2022
Merged

FinalizeTx after engine.Initialize #5783

merged 1 commit into from
Oct 18, 2022

Conversation

yperbasis
Copy link
Collaborator

@yperbasis yperbasis commented Oct 18, 2022

AuRa storage changes made by onEpochBegin should be finalized. Otherwise, SSTORE cost might be incorrect in block transactions when EIP-2200 is active. https://gnosisscan.io/tx/0xa6d45d903c977ad237165737ebc4e34fb7756675719d112a199af858bb1275e0 is an example of a transaction on Gnosis Chain whose gas used was previously calculated incorrectly.

@yperbasis yperbasis added the gnosis Gnosis Chain label Oct 18, 2022
@yperbasis yperbasis merged commit 0fb7417 into devel Oct 18, 2022
@yperbasis yperbasis deleted the gnosis10 branch October 18, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gnosis Gnosis Chain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant