Fix eth_getProof element order #7351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to EIP-1186 the `proof` parts of the response to eth_getProof should be returned "starting with the stateRoot-Node, following the path of the SHA3 (address) as key." Currently, the proof is returned in traversal order, rather than from the root. Although all of the proof elements are there and correct, this is contrary to the EIP and will cause problems for some clients. The existing rpc test uses a map to lookup proof elements by hash, rather than by index, so this bug was not initially caught. This commit fixes the behavior, updates the existing test, and adds additional checks to the rpc test.
calmbeing
pushed a commit
to calmbeing/bsc-erigon
that referenced
this pull request
Apr 24, 2023
According to EIP-1186 the `proof` parts of the response to eth_getProof should be returned "starting with the stateRoot-Node, following the path of the SHA3 (address) as key." Currently, the proof is returned in traversal order, rather than from the root. Although all of the proof elements are there and correct, this is contrary to the EIP and will cause problems for some clients. The existing rpc test uses a map to lookup proof elements by hash, rather than by index, so this bug was not initially caught. This commit fixes the behavior, updates the existing test, and adds additional checks to the rpc test. Co-authored-by: Jason Yellick <jason@enya.ai>
gladcow
pushed a commit
to Ankr-network/erigon
that referenced
this pull request
May 4, 2023
According to EIP-1186 the `proof` parts of the response to eth_getProof should be returned "starting with the stateRoot-Node, following the path of the SHA3 (address) as key." Currently, the proof is returned in traversal order, rather than from the root. Although all of the proof elements are there and correct, this is contrary to the EIP and will cause problems for some clients. The existing rpc test uses a map to lookup proof elements by hash, rather than by index, so this bug was not initially caught. This commit fixes the behavior, updates the existing test, and adds additional checks to the rpc test. Co-authored-by: Jason Yellick <jason@enya.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to EIP-1186 the
proofparts of the response to eth_getProof should be returned "starting with the stateRoot-Node, following the path of the SHA3 (address) as key." Currently, the proof is returned in traversal order, rather than from the root.Although all of the proof elements are there and correct, this is contrary to the EIP and will cause problems for some clients. The existing rpc test uses a map to lookup proof elements by hash, rather than by index, so this bug was not initially caught.
This commit fixes the behavior, updates the existing test, and adds additional checks to the rpc test.