Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show stack for push0 #7970

Merged
merged 1 commit into from Aug 5, 2023
Merged

fix: show stack for push0 #7970

merged 1 commit into from Aug 5, 2023

Conversation

banteg
Copy link
Contributor

@banteg banteg commented Aug 4, 2023

this fixes vmtrace after shanghai

before:

VMOperation(pc=24, cost=2, ex=VMExecutedOperation(used=1942085, push=[], mem=None, store=None), sub=None, op='PUSH0', idx='14-644-13')

after:

VMOperation(pc=24, cost=2, ex=VMExecutedOperation(used=1942085, push=[HexBytes('0x00')], mem=None, store=None), sub=None, op='PUSH0', idx='14-644-13')

@Giulio2002 Giulio2002 merged commit 63ecbf8 into ledgerwatch:devel Aug 5, 2023
4 checks passed
banteg added a commit to banteg/evm-trace that referenced this pull request Aug 31, 2023
add a workaround for a bug present in latest stable erigon v2.48.1.
it is fixed in devel release, so we should remove the fix when erigon makes a new stable release.
ledgerwatch/erigon#7970
antazoey pushed a commit to ApeWorX/evm-trace that referenced this pull request Aug 31, 2023
add a workaround for a bug present in latest stable erigon v2.48.1.
it is fixed in devel release, so we should remove the fix when erigon makes a new stable release.
ledgerwatch/erigon#7970
AskAlexSharov pushed a commit that referenced this pull request Sep 6, 2023
this fixes vmtrace after shanghai

before:
```python
VMOperation(pc=24, cost=2, ex=VMExecutedOperation(used=1942085, push=[], mem=None, store=None), sub=None, op='PUSH0', idx='14-644-13')
```

after:
```python
VMOperation(pc=24, cost=2, ex=VMExecutedOperation(used=1942085, push=[HexBytes('0x00')], mem=None, store=None), sub=None, op='PUSH0', idx='14-644-13')
```
universal9622 added a commit to universal9622/evm-trace that referenced this pull request Apr 29, 2024
add a workaround for a bug present in latest stable erigon v2.48.1.
it is fixed in devel release, so we should remove the fix when erigon makes a new stable release.
ledgerwatch/erigon#7970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants