Txpool 4844 upgrades Part 2 #8213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
requested changes
Sep 18, 2023
yperbasis
reviewed
Sep 19, 2023
| backend.notifications.Accumulator.StartChange(currentBlock.NumberU64(), currentBlock.Hash(), nil, false) | ||
| backend.notifications.Accumulator.SendAndReset(ctx, backend.notifications.StateChangesConsumer, baseFee, currentBlock.GasLimit(), 0) | ||
|
|
||
| backend.notifications.Accumulator.SendAndReset(ctx, backend.notifications.StateChangesConsumer, baseFee, blobFee, currentBlock.GasLimit(), 0) |
There was a problem hiding this comment.
If we are sending pending rather than current blobFee, it makes sense to do the same for baseFee (pending instead of current).
There was a problem hiding this comment.
Yes, i will make that change as well. Meanwhile, in this case we are sending values (to txPool) with respect to the CurrentBlock, which is where the sync is at. Should we consider sending values for the canonical head instead?
There was a problem hiding this comment.
This piece of code looks like a kludge. I'd leave currentBlock as is since it seems to be doing the job.
yperbasis
reviewed
Sep 19, 2023
yperbasis
approved these changes
Sep 19, 2023
github-merge-queue bot
pushed a commit
to ledgerwatch/erigon-lib
that referenced
this pull request
Sep 20, 2023
Fix some peer-review comments from the last related PR, and add some enhancements #### Change summary - Addition of a flag for BlobSlots - for max allowed blobs per account in txpool - Use BlobFee from the block to validate txs in the pool - Let go of unwound blob txn's onNewBlock, if not present in the cache; we don't request them again from the network Related: ledgerwatch/erigon#8213 ledgerwatch/interfaces#195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some peer-review changes from the last related PR.
Addition of a flag for BlobSlots - for max allowed blobs per account in txpool.
Use BlobFee from the block to validate txs in the pool.
See also ledgerwatch/erigon-lib#1125