Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bor fix rpcdeamon engine initialization #8390

Merged
merged 9 commits into from
Oct 6, 2023

Conversation

mh0lt
Copy link
Contributor

@mh0lt mh0lt commented Oct 6, 2023

This fixes 2 related issues:

  • Now that the bor consensus engine is required for queries it can't be created based on the pretense of a db directory, but must be based on chain config read from the db. Using the DB presence causes Bor to get instantiated for non bor chains which breaks.
  • At the moment eth_calls on a remote daemon don't check Bor headers prior to calling the EVM code as it was just using a fake ETHash instance - which performs ETH header validation only.

The current version is mostly working but needs adapting to perform lazy initialization of the engine.

@mh0lt mh0lt added the polygon label Oct 6, 2023
@mh0lt mh0lt merged commit ca3ad09 into devel Oct 6, 2023
4 checks passed
@mh0lt mh0lt deleted the bor_fix_rpcdeamon_engine_initialization branch October 6, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant