Shanghai/Agra HF

[anshalshukla]

No description provided.

[0xKrishna]

Left few comments, Rest LGTM.

[mh0lt]

You can't reference github.com/ledgerwatch/erigon/core/rawdb from erigon-lib code. Erigon lib needs to be self contained.

This will need to be fixed before ci will pass.

[yperbasis]

@anshalshukla Why introduce AgraBlock to the code? Can't we simply use ShanghaiBlock instead?

[anshalshukla]

The problem is bor HF are based on block whereas ethereum now have it time based. Using ShanghaiBlock would mean we cannot use IsShanghai function as it takes in timestamp as parameter whereas bor needs a block there to figure out the fork
@yperbasis

[yperbasis]

The problem is bor HF are based on block whereas ethereum now have it time based. Using ShanghaiBlock would mean we cannot use IsShanghai function as it takes in timestamp as parameter whereas bor needs a block there to figure out the fork @yperbasis

Understood, makes sense

[yperbasis]

If I understand correctly, withdrawals shouldn't be present at all in Agra blocks. If that's the case, withdrawals must be nil rather than an empty array.

[AlexeyAkhunov]

Causes this error on bor-mainnet node (works on the previous commit though):

[INFO] [10-20|21:03:05.822] [7/15 Execution] Blocks execution        from=48956844 to=48957092
[EROR] [10-20|21:03:05.823] Staged Sync                              err="runtime error: index out of range [-1], trace: [stageloop.go:105 panic.go:890 panic.go:113 chain_config.go:587 chain_config.go:543 state_transition.go:446 state_transition.go:185 state_processor.go:61 state_processor.go:118 blockchain.go:121 stage_execute.go:177 stage_execute.go:471 default_stages.go:120 sync.go:430 sync.go:331 stageloop.go:149 stageloop.go:71 asm_amd64.s:1598]"

[yperbasis]

Causes this error on bor-mainnet node (works on the previous commit though):

[INFO] [10-20|21:03:05.822] [7/15 Execution] Blocks execution        from=48956844 to=48957092
[EROR] [10-20|21:03:05.823] Staged Sync                              err="runtime error: index out of range [-1], trace: [stageloop.go:105 panic.go:890 panic.go:113 chain_config.go:587 chain_config.go:543 state_transition.go:446 state_transition.go:185 state_processor.go:61 state_processor.go:118 blockchain.go:121 stage_execute.go:177 stage_execute.go:471 default_stages.go:120 sync.go:430 sync.go:331 stageloop.go:149 stageloop.go:71 asm_amd64.s:1598]"

Should be fixed by #8553