Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore full sync mode #90

Merged
merged 15 commits into from
Sep 17, 2019
Merged

Restore full sync mode #90

merged 15 commits into from
Sep 17, 2019

Conversation

JekaMas
Copy link
Contributor

@JekaMas JekaMas commented Aug 30, 2019

closes #89

  • for some reason after go 1.12.x a few tests were broken

@JekaMas JekaMas changed the title [WIP] Restore full sync mode Restore full sync mode Sep 16, 2019
AlexeyAkhunov
AlexeyAkhunov approved these changes Sep 17, 2019
View reviewed changes
build/env.sh Outdated
@@ -8,20 +8,13 @@ if [ ! -f "build/env.sh" ]; then
fi

# Create fake Go workspace if it doesn't exist yet.
workspace="$PWD/build/_workspace"
workspace="$GOPATH"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces dependency on GOPATH, doesn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good point! I had an old master in the branch, now it should be updated.

b00ris
b00ris approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@b00ris b00ris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/blockchain.go Outdated

func (bc *BlockChain) NotifyHeightKnownBlock(h uint64) {
if atomic.LoadUint64(bc.highestKnownBlock) < h {
atomic.StoreUint64(bc.highestKnownBlock, h)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be a datarace. Why Notify?

b00ris
b00ris reviewed Sep 17, 2019
View reviewed changes
params/eip_ctx.go
if block == nil {
return configKey(-1)
}
return configKey(block.Uint64() + 1000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not found -1000

@b00ris b00ris merged commit ff70751 into master Sep 17, 2019
@AlexeyAkhunov AlexeyAkhunov deleted the restore-full-sync-mode-#89 branch December 21, 2019 17:28
@lucyzhang314 lucyzhang314 mentioned this pull request Aug 10, 2021
Closed
setunapo pushed a commit to setunapo/bsc-erigon that referenced this pull request May 30, 2023
@calmbeing
update params of request packet to match bsc-geth (ledgerwatch#90)
fb2ee06
battlmonstr pushed a commit that referenced this pull request Sep 14, 2023
@AskAlexSharov
Pool: switch to PendingBaseFee (#90)
f5fa03d
cffls pushed a commit to cffls/erigon that referenced this pull request Jan 30, 2024
@V-Staykov
dixed eth_syncing to use zkEvm stages (ledgerwatch#90)
48e3045
jyellick referenced this pull request in bobanetwork/op-erigon Feb 26, 2024
@ImTei
Merge pull request #90 from testinprod-io/remove_failing_test
dd556a8 
Remove failing TestGnosisForkDigest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b00ris b00ris b00ris approved these changes

@AlexeyAkhunov AlexeyAkhunov AlexeyAkhunov approved these changes

@yperbasis yperbasis Awaiting requested review from yperbasis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore full sync mode
3 participants
@JekaMas @b00ris @AlexeyAkhunov