[to discuss] exec blocks without ObjectDb: Mutation over TxDb #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AskAlexSharov
commented
Aug 20, 2020
AskAlexSharov
commented
- Usage of TxDb means don't open read transaction every time you wanna read something from db.
- On fast disk it speeding genesis sync 21hour -> 17hours
- But it a bit increases complexity of stage_exec - now there is db.Begin, then tx.NewBatch, then both of them need periodical commit
- I need your advise - maybe we can simplify code somehow?
|
I don't see it as a big increase in complexity at all. Will test the full sync with it myself soon |
mandrigin
reviewed
Aug 20, 2020
| @@ -132,6 +147,9 @@ func SpawnExecuteBlocksStage(s *StageState, stateDB ethdb.Database, chainConfig | |||
| if _, err := batch.Commit(); err != nil { | |||
| return fmt.Errorf("sync Execute: failed to write batch commit: %v", err) | |||
| } | |||
| if _, err = tx.Commit(); err != nil { | |||
There was a problem hiding this comment.
what will happen when we Commit and the defer calls Rollback?
There was a problem hiding this comment.
Commit sets internal transaction object to nil, then rollback do something only if that object is not nil. So, rollback after commit must not do anything. Same for double-rollback.
There was a problem hiding this comment.
With Tx need to be more strict than with mutation: if tx not closed well - it can cause deadlock or leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.