Fixing a bug where conform panics if a field isn't a struct #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conform was choking on a field in a struct which has a type of []byte.
The problem was in the recursive Strings method in which reflection is used to figure out the number of fields in a struct. In this edge case the []byte was passed in a recursive walk of the struct which resulted in a panic when calling ift.NumFields().
This is documented here:
My solution is to return early in case the reflected variable is not a struct.
Thank you for your work!