Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples #500

Merged
merged 6 commits into from
Aug 9, 2017
Merged

Update examples #500

merged 6 commits into from
Aug 9, 2017

Conversation

arribbar
Copy link
Collaborator

@arribbar arribbar commented Aug 9, 2017

Issues

It should fix #494 and fix #495

Done

  • updated all examples to run with RN 0.47
  • bugfix swiper display
  • bugfix loadMinimal function
  • bug rendering title on Swiper and SwiperNumber examples
  • bug building examples with react-native-photo-view. Removed the package for now
  • add yarn command

@arribbar
Copy link
Collaborator Author

arribbar commented Aug 9, 2017

@mrdezzods Can you check it ?

@mrdezzods
Copy link
Collaborator

@arribbar I will check it once I get back to my computer. Thanks

@mrdezzods
Copy link
Collaborator

Code looks ok. You can update the gifs as well (if there is UI change in the examples)

@arribbar
Copy link
Collaborator Author

arribbar commented Aug 9, 2017

The UI does not change except for Swiper and SwiperNumber. But it is because renderTitle do not work. I would let it like that and add one issue. I removed PhotoView example

@mrdezzods mrdezzods merged commit feac148 into master Aug 9, 2017
@arribbar arribbar deleted the updateExample branch August 10, 2017 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swiper not showing [1.5.7] Swiper view "disappeared" since upgrade
2 participants