Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong calculation of width and height after device rotation #581

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Fix wrong calculation of width and height after device rotation #581

merged 1 commit into from
Sep 28, 2017

Conversation

kostyaVyrodov
Copy link

@kostyaVyrodov kostyaVyrodov commented Sep 21, 2017

Is it a bugfix?

Describe what you've done:

  • I moved code that gets width and height to the initState() function

Steps to reproduce the issue (iOS):

Precondition:
<Swiper index={this.state.selectedPageIndex} onIndexChanged={(index) => this.setState({ selectedPageIndex: index })}> <SomeView/> </Swiper>

  • Add function to handle onIndexChanged
  • Pass updatedIndex

Steps:

  • Rotate device
  • Swipe

@arribbar
Copy link
Collaborator

Thanks @kostyaVyrodov

@arribbar arribbar merged commit 0dbe73b into leecade:master Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landscape mode
2 participants