Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuning inaccuracy #4

Open
jwt27 opened this issue Aug 4, 2023 · 0 comments
Open

Tuning inaccuracy #4

jwt27 opened this issue Aug 4, 2023 · 0 comments

Comments

@jwt27
Copy link

jwt27 commented Aug 4, 2023

Noticed you used these FNUM values, presumably copied from the original driver:

SHORT fnum[12] = {
514, 544, 577, 611, /* G , G#, A , A# */
647, 686, 727, 770, /* B , C , C#, D */
816, 864, 916, 970 /* D#, E , F, F# */
};

I believe those were calculated with fs=50000 (instead of 49716), so the pitch is about 10 cents off. Not immediately noticeable, but might become an issue if someone uses this for music production and expects it to be in tune with other sounds.

The following numbers will be more accurate:

517, 547, 580, 615,
651, 690, 731, 774,
820, 869, 921, 975

On the other hand, this could clash with any fixed-pitch voices in the existing patch banks, so changing it might not improve the general use case. But maybe that's only percussion. You decide :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant