Skip to content

Commit

Permalink
refactor(Message): 출력할 때 사용하는 Message에서 toString() 대신 getMessage()를 사용
Browse files Browse the repository at this point in the history
- 3주차 공통 피드백 반영
toString()은 주로 객체의 상태를 보기 위한 로그 메세지의 성격이 강함
따라서 출력을 위해 사용하는 메세지는 getter로 구현함
  • Loading branch information
leegwichan committed Nov 16, 2022
1 parent 32a224c commit fe2c7a6
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/main/java/device/input/ConsoleInput.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ private int stringToInt(String string) {
try {
return Integer.parseInt(string);
} catch (NumberFormatException e) {
throw new IllegalArgumentException(InputErrorMessage.NOT_FORM_CORRECT.toString());
throw new IllegalArgumentException(InputErrorMessage.NOT_FORM_CORRECT.getMessage());
}
}
}
2 changes: 1 addition & 1 deletion src/main/java/device/input/InputErrorMessage.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public enum InputErrorMessage implements Message {
}

@Override
public String toString() {
public String getMessage() {
return message;
}
}
3 changes: 1 addition & 2 deletions src/main/java/device/message/Message.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package device.message;

public interface Message {

String toString();
String getMessage();
}
2 changes: 1 addition & 1 deletion src/main/java/lotto/lotto/Lotto.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public Lotto(List<Integer> numbers, LottoSetting setting) {

private void validate(List<Integer> numbers, LottoSetting setting) {
if (!setting.isValidNumbers(numbers)) {
throw new IllegalArgumentException(ExceptionMessage.LOTTO_FORM_NOT_MATCHED.toString());
throw new IllegalArgumentException(ExceptionMessage.LOTTO_FORM_NOT_MATCHED.getMessage());
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/lotto/lotto/LottoShop.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public List<Lotto> buyLotto(int totalPrice) {

private int calculateCountOfLotto(int totalPrice) {
if (totalPrice % price != 0) {
throw new IllegalArgumentException(ExceptionMessage.NOT_DIVIDED_PRISE.toString());
throw new IllegalArgumentException(ExceptionMessage.NOT_DIVIDED_PRISE.getMessage());
}
return totalPrice / price;
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/lotto/message/ExceptionMessage.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public enum ExceptionMessage implements Message {
}

@Override
public String toString() {
public String getMessage() {
return message;
}
}
2 changes: 1 addition & 1 deletion src/main/java/lotto/message/InputRequestMessage.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public enum InputRequestMessage implements Message {
}

@Override
public String toString() {
public String getMessage() {
return message;
}
}
2 changes: 1 addition & 1 deletion src/main/java/lotto/winningnumber/WinningNumber.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public WinningNumber(List<Integer> numbers, List<Integer> bonusNumbers, WinningN

private void validate(List<Integer> numbers, List<Integer> bonusNumbers, WinningNumberSetting setting) {
if (!setting.isValidateNumbers(numbers, bonusNumbers)) {
throw new IllegalArgumentException(ExceptionMessage.WINNING_NUMBER_FORM_NOT_MATCHED.toString());
throw new IllegalArgumentException(ExceptionMessage.WINNING_NUMBER_FORM_NOT_MATCHED.getMessage());
}
}

Expand Down

0 comments on commit fe2c7a6

Please sign in to comment.