remove contrib from handlers imports #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leej3
force-pushed
the
update-references-to-handlers
branch
2 times, most recently
from
0331135
to
742fe80
Compare
leej3
force-pushed
the
move-contrib-handler-files
branch
from
a827eb7
to
ed7db21
Compare
* migrate ignite.contrib.handlers move loggers and other class from contrib to ignite.handlers make changes in a backwards compatible manner fix circular imports that happened during the migration in ignite/__init__.py and ignite/handlers/__init__.py * update tests move tests to ignite.handlers along with fixtures and changing the imports add a test to ensure deprecation warnings for ignite.contrib.handlers * improve docs mark as deprecated and provide link to migrated functionality * make alternative fix for circular import * add modules to contrib handlers namespace previously this occured as a side effect, adding it explicitly now.
leej3
force-pushed
the
update-references-to-handlers
branch
from
742fe80
to
ea84f3d
Compare
* add Entropy metric * fix error in torch.randint * update Entropy metric to support other shapes * Update ignite/metrics/entropy.py Co-authored-by: vfdev <vfdev.5@gmail.com> * update test of Entropy metric * Update ignite/metrics/entropy.py * format code * fix error in converting Tensor to ndarray --------- Co-authored-by: vfdev <vfdev.5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from pytorch#3204. Separated for better clarity in the file diffing.