Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AW3::S3::FileIterator goes into a loop if the last file name in a bucket contains a "+" sign #5

Closed
leejo opened this issue Apr 5, 2016 · 0 comments
Closed

AW3::S3::FileIterator goes into a loop if the last file name in a bucket contains a "+" sign #5

leejo opened this issue Apr 5, 2016 · 0 comments

Comments

@leejo
Copy link
Owner

leejo commented Apr 5, 2016

Because "+" in a URL gets interpreted as a space. The fix is to URL-quote the "+" as "%2B." The characters "&" and "?" should be quoted as well.
leejo added a commit that referenced this issue Apr 7, 2016
@leejo
ref #5 - check filenames uri_encoded in GET reqs
28b1eb1 
looks fine to me. possibly related to #3 and the signature? anyway
it seems the URLs are correctly encoded so need more info here
leejo added a commit that referenced this issue Apr 7, 2016
@leejo
ref #5 - favour URI::Escape over URI::Encode
7e115bd 
because we are already using the former, no need to introduce extra
dependency
@leejo leejo closed this as completed in f0fc7b5 Apr 7, 2016
leejo added a commit that referenced this issue Apr 7, 2016
@leejo
resolve #4, resolve #5 - DNS bucket check / URI escaping
10bb998 
be a bit smarter in the _is_dns_bucket check (actually do checking)
to make sure a none valid DNS bucket name isn't marked as valid so
the bucket is used in the path rather than the hostname

make sure to uri_escape files in paths to avoid infinite loops due
to spaces in filenames

bump VERSION and Changes for CPAN release
leejo added a commit that referenced this issue Apr 7, 2016
@leejo
resolve #4, resolve #5 - DNS bucket check / URI escaping
bf4c994 
be a bit smarter in the _is_dns_bucket check (actually do checking)
to make sure a none valid DNS bucket name isn't marked as valid so
the bucket is used in the path rather than the hostname

make sure to uri_escape files in paths to avoid infinite loops due
to spaces in filenames

bump VERSION and Changes for CPAN release
leejo added a commit that referenced this issue Apr 8, 2016
@leejo
ref #4, ref #5, fix more DNS bucket endpoints
ef7f548 
couple more places we need to check if the bucket is a valid DNS
bucket and DTRT if it is not, also another places to uri_escape
the params

it seems this code is poorly factored and has some repetition that
code be refactored out, but at the moment i'm not inclined to fix
leejo added a commit that referenced this issue Apr 8, 2016
@leejo
ref #4, ref #5, fix more DNS bucket endpoints
9cb7967 
couple more places we need to check if the bucket is a valid DNS
bucket and DTRT if it is not, also another places to uri_escape
the params

it seems this code is poorly factored and has some repetition that
code be refactored out, but at the moment i'm not inclined to fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leejo