resolve #3 - increase test coverage

basic subroutine test coverage for several methods that currently
have zero test coverage

Changes

@@ -12,6 +12,10 @@
     - All *documentation* for HTML functionality in CGI has been moved into
       its own namespace: CGI::HTML::Functions - although the functionality
       continues to exist within CGI.pm so there are no code changes required
+      (GH #142)
+
+    [ TESTING ]
+    - Increase test coverage (GH #3)
 
     [ INTERNALS ]
     - Cwd made a TEST_REQUIRES rather than a BUILD_REQUIRES in Makefile.PL

MANIFEST

@@ -34,7 +34,6 @@ t/delete.t
 t/end_form.t
 t/form.t
 t/function.t
-t/gen-tests/gen-start-end-tags.pl
 t/gh-155.t
 t/headers.t
 t/headers/attachment.t

Makefile.PL

@@ -1,8 +1,6 @@
 use ExtUtils::MakeMaker;
 my $mm = $ExtUtils::MakeMaker::VERSION;
 
-system( "perl", "t/gen-tests/gen-start-end-tags.pl" );
-
 # See lib/ExtUtils/MakeMaker.pm for details of how to influence
 # the contents of the Makefile that is written.
 WriteMakefile(

lib/CGI/Carp.pm

@@ -494,7 +494,7 @@ sub carpout {
 
     open(SAVEERR, ">&STDERR");
     open(STDERR, ">&$no") or 
-	( print SAVEERR "Unable to redirect STDERR: $!\n" and exit(1) );
+	( print SAVEERR "Unable to redirect >&$no: $!\n" and exit(1) );
 }
 
 sub warningsToBrowser {

lib/CGI/Push.pm

@@ -82,6 +82,7 @@ sub do_sleep {
         sleep($delay);
     } else {
         select(undef,undef,undef,$delay);
+		return $delay;
     }
 }
 

t/carp.t

@@ -3,7 +3,7 @@
 
 use strict;
 
-use Test::More tests => 64;
+use Test::More tests => 71;
 use IO::Handle;
 
 use CGI::Carp;
@@ -425,3 +425,16 @@ untie *STDOUT;
  like $result[0] => qr/Message ToBrowser/, 'die message for ToBrowser = 0 is OK';
  ok !$result[1], 'No output for ToBrowser = 0';
 
+*CGI::Carp::die = sub { &$CGI::Carp::DIE_HANDLER; return 1 };
+*CGI::Carp::warn = sub { return 1 };
+
+CGI::Carp::set_die_handler( sub { pass( "die handler" ); return 1 } );
+ok( CGI::Carp::confess(),'confess' );
+ok( CGI::Carp::croak(),'croak' );
+ok( CGI::Carp::carp(),'carp' );
+ok( CGI::Carp::cluck(),'cluck' );
+
+use File::Temp;
+my $fh = File::Temp->new;
+
+ok( CGI::Carp::carpout( $fh ),'carpout' );

t/cgi.t

@@ -0,0 +1,73 @@
+#!/usr/local/bin/perl
+
+# coverage for testing that doesn't sit elsewhere
+
+use strict;
+use warnings;
+
+use Test::More tests => 25;
+use Test::Deep;
+use Test::Warn;
+
+use CGI ();
+
+# Set up a CGI environment
+$ENV{REQUEST_METHOD}  = 'GET';
+$ENV{QUERY_STRING}    = 'game=chess&game=checkers&weather=dull';
+
+isa_ok( my $q = CGI->new,'CGI' );
+
+# undocumented ->r method, seems to be a temp store?
+$q->r( 'foo' );
+is( $q->r,'foo','r' );
+
+diag( "cgi-lib.pl routines" );
+
+ok( $q->ReadParse,'ReadParse' );
+is( $q->PrintHeader,$q->header,'PrintHeader' );
+is( $q->HtmlTop,$q->start_html,'HtmlTop' );
+is( $q->HtmlBot,$q->end_html,'HtmlBot' );
+
+cmp_deeply(
+	[ my @params = CGI::SplitParam( "foo\0bar" ) ],
+	[ qw/ foo bar /],
+	'SplitParam'
+);
+
+ok( $q->MethGet,'MethGet' );
+ok( ! $q->MethPost,'MethPost' );
+ok( ! $q->MethPut,'MethPut' );
+
+note( "TIE methods" );
+ok( ! $q->FIRSTKEY,'FIRSTKEY' );
+ok( ! $q->NEXTKEY,'NEXTKEY' );
+ok( ! $q->CLEAR,'CLEAR' );
+
+is( $q->version,$CGI::VERSION,'version' );
+is( $q->as_string,'<ul></ul>','as_string' );
+
+is( ( $q->_style )[0],'<link rel="stylesheet" type="text/css" href="" />','_style' );
+is( $q->state,'http://localhost','state' );
+
+$CGI::NOSTICKY = 0;
+ok( $q->nosticky( 1 ),'nosticky' );
+is( $CGI::NOSTICKY,1,' ... sets $CGI::NOSTICKY' );
+
+$CGI::NPH = 0;
+ok( $q->nph( 1 ),'nph' );
+is( $CGI::NPH,1,' ... sets $CGI::NPH' );
+
+$CGI::CLOSE_UPLOAD_FILES = 0;
+ok( $q->close_upload_files( 1 ),'close_upload_files' );
+is( $CGI::CLOSE_UPLOAD_FILES,1,' ... sets $CGI::CLOSE_UPLOAD_FILES' );
+
+cmp_deeply(
+	$q->default_dtd,
+	[
+		'-//W3C//DTD HTML 4.01 Transitional//EN',
+		'http://www.w3.org/TR/html4/loose.dtd'
+	],
+	'default_dtd'
+);
+
+ok( ! $q->private_tempfiles,'private_tempfiles' );

t/push.t

@@ -9,18 +9,7 @@ ok( my $q = CGI::Push->new(), 'create a new CGI::Push object' );
 # test the simple_counter() method
 like( join('', $q->simple_counter(10)) , '/updated.+?10.+?times./', 'counter' );
 
-# test do_sleep, except we don't want to bog down the tests
-# there's also a potential timing-related failure lurking here
-# change this variable at your own risk
-my $sleep_in_tests = 0;
-
-SKIP: {
-	skip( 'do_sleep() test may take a while', 1 ) unless $sleep_in_tests;
-
-	my $time = time;
-	CGI::Push::do_sleep(2);
-	is(time - $time, 2, 'slept for a while' );
-}
+ok( CGI::Push::do_sleep(0.01),'do_sleep' );
 
 # test push_delay()
 ok( ! defined $q->push_delay(), 'no initial delay' );

t/util.t

@@ -5,10 +5,16 @@
 
 $| = 1;
 
-use Test::More tests => 77;
+use Test::More tests => 80;
 use Test::Deep;
 use Config;
-use_ok ( 'CGI::Util', qw(escape unescape rearrange) );
+use_ok ( 'CGI::Util', qw(
+	escape
+	unescape
+	rearrange
+	ebcdic2ascii
+	ascii2ebcdic
+) );
 
 # ASCII order, ASCII codepoints, ASCII repertoire
 
@@ -79,3 +85,6 @@ for ( 1 .. 20 ) {
 	);
 }
 
+ok( CGI::Util::utf8_chr( "1",1 ),'utf8_chr' );
+ok( my $ebcdic = ascii2ebcdic( "A" ),'ascii2ebcdic' );
+is( ebcdic2ascii( $ebcdic ),'A','ebcdic2ascii' );