Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information loss in url() #267

Closed
zaucker opened this issue Jun 18, 2024 · 2 comments
Closed

Information loss in url() #267

zaucker opened this issue Jun 18, 2024 · 2 comments

Comments

@zaucker
Copy link

zaucker commented Jun 18, 2024

The fix for #259 leads to information loss, in particular this line:

+       $url =~ s!/$!!;

as it is not clear anymore if the URL was pointing to a directory or not.
This seems unnecessary for fix 259.
@leejo leejo closed this as completed in 01ac975 Jun 19, 2024
@leejo
Copy link
Owner

leejo commented Jun 19, 2024

@zaucker - sorry about that, the fix was to honour the existing test suite's expectations about trailing slashes in the call to ->url and clearly they are wrong. Fixed and v4.66 on its way to CPAN.

leejo added a commit that referenced this issue Jun 19, 2024
@leejo
fix #267 - restore trailing slash in ->url
a5485b5 
the fix for #259 leads to information loss, in particular this line:

    $url =~ s!/$!!;

as it is not clear anymore if the URL was pointing to a directory or
not. it was done this way to honor the existing tests, but it seems they
are misleading and wrong - fix those also

w/r/t 6cbb44b

bump VERSION and Changes for CPAN release
@zaucker
Copy link
Author

zaucker commented Jun 19, 2024

@zaucker - sorry about that, the fix was to honour the existing test suite's expectations about trailing slashes in the call to ->url and clearly they are wrong. Fixed and v4.66 on its way to CPAN.

Cool, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leejo @zaucker