Skip to content

Commit

Permalink
Kwalitee improvements
Browse files Browse the repository at this point in the history
use strict, warnings (we were already doing so via Moo but the
cpants kwalitee looks for for these), remove TryCatch from the POD
to prevent cpants thinking we're using it
  • Loading branch information
leejo committed May 22, 2016
1 parent d5f85b8 commit 6916f1d
Show file tree
Hide file tree
Showing 19 changed files with 52 additions and 9 deletions.
Binary file removed .DS_Store
Binary file not shown.
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -13,3 +13,4 @@
cover_db
end_to_end.sh
examples/
.DS_Store
3 changes: 3 additions & 0 deletions Changes
@@ -1,5 +1,8 @@
Revision history for Business-Mondo

0.03 2015-05-22
- Kwalitee improvements

0.02 2015-04-28
- Tweak merchant coercion to handle null values

Expand Down
1 change: 1 addition & 0 deletions MANIFEST
@@ -1,5 +1,6 @@
Changes
Makefile.PL
MANIFEST
README.md
end_to_end_emulated.sh
lib/Business/Mondo.pm
Expand Down
6 changes: 2 additions & 4 deletions README.md
Expand Up @@ -11,7 +11,7 @@ Business::Mondo - Perl library for interacting with the Mondo API

# VERSION

0.02
0.03

# DESCRIPTION

Expand Down Expand Up @@ -91,9 +91,7 @@ will, for the most part, return new instances of objects.

Any problems or errors will result in a Business::Mondo::Exception
object being thrown, so you should wrap any calls to the library in the
appropriate error catching code (TryCatch in the below example):

use TryCatch;
appropriate error catching code (ideally a module from CPAN):

try {
...
Expand Down
9 changes: 5 additions & 4 deletions lib/Business/Mondo.pm
Expand Up @@ -11,7 +11,7 @@ Business::Mondo - Perl library for interacting with the Mondo API
=head1 VERSION
0.02
0.03
=head1 DESCRIPTION
Expand Down Expand Up @@ -91,9 +91,7 @@ will, for the most part, return new instances of objects.
Any problems or errors will result in a Business::Mondo::Exception
object being thrown, so you should wrap any calls to the library in the
appropriate error catching code (TryCatch in the below example):
use TryCatch;
appropriate error catching code (ideally a module from CPAN):
try {
...
Expand Down Expand Up @@ -124,6 +122,9 @@ stack trace in the event of exceptions:
=cut

use strict;
use warnings;

use Moo;
with 'Business::Mondo::Version';

Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Account.pm
Expand Up @@ -10,6 +10,9 @@ A class for a Mondo account, extends L<Business::Mondo::Resource>
=cut

use strict;
use warnings;

use Moo;
extends 'Business::Mondo::Resource';
with 'Business::Mondo::Utils';
Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Address.pm
Expand Up @@ -10,6 +10,9 @@ A class for a Mondo address, extends L<Business::Mondo::Resource>
=cut

use strict;
use warnings;

use Moo;
extends 'Business::Mondo::Resource';
with 'Business::Mondo::Utils';
Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Attachment.pm
Expand Up @@ -10,6 +10,9 @@ A class for a Mondo attachment, extends L<Business::Mondo::Resource>
=cut

use strict;
use warnings;

use Moo;
extends 'Business::Mondo::Resource';
with 'Business::Mondo::Utils';
Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Balance.pm
Expand Up @@ -10,6 +10,9 @@ A class for a Mondo balance, extends L<Business::Mondo::Resource>
=cut

use strict;
use warnings;

use Moo;
extends 'Business::Mondo::Resource';
with 'Business::Mondo::Utils';
Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Client.pm
Expand Up @@ -11,6 +11,9 @@ there is nothing you should be doing with this.
=cut

use strict;
use warnings;

use Moo;
with 'Business::Mondo::Utils';
with 'Business::Mondo::Version';
Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Currency.pm
Expand Up @@ -10,6 +10,9 @@ A role containing currency attributes / methods
=cut

use strict;
use warnings;

use Moo::Role;
use Types::Standard qw/ :all /;
use Data::Currency;
Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Exception.pm
Expand Up @@ -11,6 +11,9 @@ module.
=cut

use strict;
use warnings;

use Moo;
use Carp qw/ cluck /;

Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Merchant.pm
Expand Up @@ -10,6 +10,9 @@ A class for a Mondo merchant, extends L<Business::Mondo::Resource>
=cut

use strict;
use warnings;

use Moo;
extends 'Business::Mondo::Resource';
with 'Business::Mondo::Utils';
Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Resource.pm
Expand Up @@ -11,6 +11,9 @@ behaviour. You shouldn't use this class directly, but extend it instead.
=cut

use strict;
use warnings;

use Moo;
use Carp qw/ confess carp /;
use Cpanel::JSON::XS;
Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Transaction.pm
Expand Up @@ -10,6 +10,9 @@ A class for a Mondo transaction, extends L<Business::Mondo::Resource>
=cut

use strict;
use warnings;

use Moo;
extends 'Business::Mondo::Resource';
with 'Business::Mondo::Utils';
Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Utils.pm
Expand Up @@ -10,6 +10,9 @@ A role containing Mondo utilities.
=cut

use strict;
use warnings;

use Moo::Role;

=head1 METHODS
Expand Down
5 changes: 4 additions & 1 deletion lib/Business/Mondo/Version.pm
Expand Up @@ -10,9 +10,12 @@ A role for a Mondo version information.
=cut

use strict;
use warnings;

use Moo::Role;

$Business::Mondo::VERSION = '0.02';
$Business::Mondo::VERSION = '0.03';
$Business::Mondo::API_VERSION = 'v1';
$Business::Mondo::API_URL = 'https://api.getmondo.co.uk';

Expand Down
3 changes: 3 additions & 0 deletions lib/Business/Mondo/Webhook.pm
Expand Up @@ -10,6 +10,9 @@ A class for a Mondo webhook, extends L<Business::Mondo::Resource>
=cut

use strict;
use warnings;

use Moo;
extends 'Business::Mondo::Resource';

Expand Down

0 comments on commit 6916f1d

Please sign in to comment.