Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking Urgent Problem #6

Closed
cristian-sima opened this issue Jul 9, 2017 · 4 comments
Closed

Blocking Urgent Problem #6

cristian-sima opened this issue Jul 9, 2017 · 4 comments

Comments

@cristian-sima
Copy link

cristian-sima commented Jul 9, 2017

Hi.

It seems the package github.com/cockroachdb/apd was update yesterday and I am getting this.

github.com/leekchan/accounting
../../leekchan/accounting/formatnumber.go:79: d.ToStandard undefined (type *apd.Decimal has no field or method ToStandard)
../../leekchan/accounting/formatnumber.go:139: d.ToStandard undefined (type *apd.Decimal has no field or method ToStandard)

@leekchan Can you fix the problem?

@leekchan
Copy link
Owner

leekchan commented Jul 9, 2017

Thanks for your reporting.

I've rollbacked the pull request #5. It seems that ToStandard was removed from the cockroachdb/apd.

@leekchan
Copy link
Owner

leekchan commented Jul 9, 2017

As mentioned in the pull request (cockroachdb/apd#60), ToStandard has been removed. But the author of the pull request said that it can be replaced by the 'f' format.

@tamalsaha Could you fix the pull request #5? If you don't have enough time, I'll try it. Thanks!

@tamalsaha
Copy link
Contributor

tamalsaha commented Jul 9, 2017

I am going to look into this.

@cristian-sima
Copy link
Author

Thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants