add Format method #60
Conversation
|
This change is |
|
Ping @knz. |
decimal_test.go
Outdated
| g: "0e+2", | ||
| }, | ||
| } | ||
| verbs := []string{"e", "E", "f", "g", "G"} |
There was a problem hiding this comment.
to make linters happy, please consider using verbs := []string{"%e", "%E", ...} here and Sprintf(v, d) below.
format.go
Outdated
| if d.Exponent <= 0 && adj >= adjExponentLimit { | ||
| return fmtF(buf, d, digits) | ||
| } | ||
| return fmtE(buf, fmt+'e'-'g', d, digits) |
There was a problem hiding this comment.
I am not familiar with this syntax in Go fmt + 'e' - 'g' what does it mean? In C that would be equivalent to fmt - 2
There was a problem hiding this comment.
This is copied from https://github.com/golang/go/blob/fcc35147d5940d5b077586c02a97894c3edf870d/src/math/big/ftoa.go?utf8=%E2%9C%93#L148
It needs to convert the either g or G into a e or E since that's what fmtE expects. So it is indeed fmt - 2, but attempting to do that in a way that illustrates the intention.
There was a problem hiding this comment.
Thank you! Perhaps a comment would help too :)
| // handle like 'G' | ||
| format = 'G' | ||
| default: | ||
| fmt.Fprintf(s, "%%!%c(*apd.Decimal=%s)", format, d.String()) |
|
👍 great functionality! |
Supports e, E, f, g, G, s, v.
ToSci has been removed and is now just String, which wraps .Text('G').
ToStandard has been removed, but can still be produced using the 'f'
format. The precision field is not supported because that could require
rounding and we don't have a context. Instead, the format methods here
always display the full precision. Although big.Float doesn't implement
's', I think we safely can because the precision is always fully
displayed.
Fixes #19
Supports e, E, f, g, G, s, v.
ToSci has been removed and is now just String, which wraps .Text('G').
ToStandard has been removed, but can still be produced using the 'f'
format. The precision field is not supported because that could require
rounding and we don't have a context. Instead, the format methods here
always display the full precision. Although big.Float doesn't implement
's', I think we safely can because the precision is always fully
displayed.
Fixes #19