Test patterns against hostname:port instead of just domain

[merkledo]

With this change you can use the indicator for projects on localhost (with just different ports, not hostnames) as well.

Shouldn't have any side effects on the default umbraco.io rules. Otherwise: @merkledo + sorry ;)

[leekelleher]

Thanks @dmerkle! Good idea! I'll review and merge in.

[leekelleher]

Hi @dmerkle, sorry, I know this was a couple of months ago, I've only got around to reviewing it.

Do you have an example of the config values?

Since location.host contains the port number, I think we'll need to amend the default regex for "localhost"?

[merkledo]

Hi @leekelleher, do you mean like these:
var config = [
{ pattern: "^localhost:8010$", color: "1d1d99" },
{ pattern: "^localhost:8020$", color: "1d991d" },
{ pattern: "^localhost:8030$", color: "991d1d" }
];

[leekelleher]

Thanks @dmerkle. I'm wondering what the default value for "localhost" should be. It is currently "^localhost$", but with port numbers being used as part of the RegEx match, it wouldn't work out of the box.

I'll experiment with it when I next get chance to work on the code 👍

[leekelleher]

I finally got around to merging this in, thanks @merkledo! Apologies for my long delay.

[merkledo]

Nice! @leekelleher thanks for merging.