Fix winrate updating #180
Merged
Fix winrate updating #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mardak
reviewed
Jun 23, 2018
classes/dbutils.js
Outdated
| @@ -52,6 +58,7 @@ async function update_matches_stats_cache(db, match_id, is_network1_win) { | |||
| } else { | |||
| match.network1_losses += 1; | |||
| } | |||
| _update_winrate(matches.slice(0, 1)); | |||
There was a problem hiding this comment.
The match being updated isn't always the first match. Probably could just pass in [match]
It is not always the first match being updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winrate and SPRT value also needs to be updated when cache updates