AutoGTP should save its work in case a reboot is required mid-game

[Nazgand]

I have killed AutoGTP at times, and have not noticed it starting from a mid-game position when running AutoGTP again.

[Friday9i]

To close it and saving games, type "q + Enter", it saves file(s) and makes a clean exit, and reload everything when you launch it again : -)

[gcp]

This would require dumping out the info every move, rather than every game. Not sure we want to do this.

[Nazgand]

@Friday9i Thanks. Where did you learn that? I did not notice it in the README or the FAQ. Perhaps the README or FAQ should be updated? Does a manual exist which I am not aware of?

[LRGB]

@gcp commented on Jun 8, 2018, 2:04 PM GMT-3:

This would require dumping out the info every move, rather than every game. Not sure we want to do this.

What about an autodump every 100 moves? I dont know how often people experience data loss to determine if this is worth the effort or not...

[Nazgand]

I am satisfied knowing `q + Enter'. If games are autosaved, it may be better to do in per unit of time (e.g. 5-10 minutes) rather than every n moves to account for differences in computing speed.

[Nazgand]

Does some other arcane command exist which will finish the current game, then exit? The README should include this info.

[d7urban]

Just do the q+Enter, then restart autogtp with the -s flag (for single game)

…

On Sun, 10 Jun 2018 at 08:53, Mark Andrew Gerads ***@***.***> wrote: Does some other arcane command exist which will finish the current game, then exit? The README should include this info. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1535 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AM9pLji6BJPtEUateTfKfd60ciw8_aT4ks5t7MJkgaJpZM4Ugcf_> .

[Nazgand]

A problem with q+Enter:
I needed to reboot, so I pressed q+Enter, then ran

autogtp -s

. A while later I decided I did not want to wait for 500 more moves before rebooting. I attempted q+Enter again and got no response. I pressed Ctrl+C, and data of 156 moves were lost.

[alreadydone]

https://github.com/gcp/leela-zero/blob/91031bfbcb09b6dc379a62e4c5e84006f0560179/autogtp/main.cpp#L155

I think removing this line would solve this problem. Actually all three quitting conditions (timeout, #games limit, q+Enter) could be made mutually compatible, not mutually exclusive, as in alreadydone@d0f054a

[marcocalignano]

@alreadydone Yes that indeed should work. Have you tested that?

[alreadydone]

alreadydone@d0f054a has been running on Big Red II for many months. I use consoleOn=false to disable q+Enter but the other two indeed can work together: autogtp exits when the time limit or the game limit is reached. Therefore I think all three can work together as well.

[marcocalignano]

Ok so let me test it (no idea when I get to it) even with the console and then I'll ask you to make a PR.

[Nazgand]

I think removing this line would solve this problem.

I have tested this, and q+Enter now works with the -s option, so I will submit a patch pull request.

[marcocalignano]

No that is wrong you want q_Enter even without the other options.

[Nazgand]

I tested @alreadydone's commit alreadydone@d0f054a , and it worked as desired. I tested it with LeelaWatcher, and LeelaWatcher does not show games which are continued. This (probably) can be fixed by having all the moves from move 1 output before generating new moves.

Another related problem is that closing LeelaWatcher midgame loses the game info; q+Enter seems not to work with LeelaWatcher. As this problem seems to not be an AutoGTP issue, I will file an issue there.

[marcocalignano]

@Nazgand Can you test it even without LeelaWatcher?

[Nazgand]

I suppose I was not clear enough. I did test it both with and without LeelaWatcher. Without LeelaWatcher, q+Enter worked as desired both with and without the -s option.

[marcocalignano]

OK then @alreadydone can you do a PR with that change?

[alreadydone]

#1580 created.