Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement resign in lc0 #20

Closed
mooskagh opened this issue Jun 2, 2018 · 7 comments
Closed

Implement resign in lc0 #20

mooskagh opened this issue Jun 2, 2018 · 7 comments
Labels
good first issue Good for newcomers
Projects
Promoting lc0 to main pipeline

Comments

@mooskagh
Copy link
Member

mooskagh commented Jun 2, 2018

From @mooskagh on May 27, 2018 16:13

Resign is not yet implemented in lc0. Implement that.

Copied from original issue: glinscott/leela-chess#674
@mooskagh mooskagh added the lc0 label Jun 2, 2018
@mooskagh mooskagh mentioned this issue Jun 2, 2018
Closed
@mooskagh mooskagh added good first issue Good for newcomers and removed lc0 labels Jun 2, 2018
@mooskagh
Copy link
Member Author

mooskagh commented Jun 2, 2018

Best done via adding bool want_resign; into BestMoveInfo

@gonzalezjo
Copy link

Do we want cfg_min_resign_moves to be changeable from the command line? That wasn't the case in lczero, but the naming conventions suggest that it was intended.

@mooskagh
Copy link
Member Author

mooskagh commented Jun 5, 2018

Why would we ever need to limit minimum number of moves before resign at all... I'd not implement this functionality unless there is justification.

As for resign threshold, that surely should be configurable.

@gonzalezjo
Copy link

No idea, but it was in lczero. I'll leave that out, then.

@killerducky
Copy link
Contributor

Just for history: It was originally in LZGo so it doesn't instantly resign handicap games without at least trying. They later modified it with more stuff like scaled based on handicap stones.

@dubslow
Copy link
Member

dubslow commented Jun 6, 2018

See #47 .

@dubslow dubslow mentioned this issue Jun 12, 2018
Merged
@dubslow dubslow moved this from To do to In progress in Promoting lc0 to main pipeline Jun 12, 2018
@dubslow
Copy link
Member

dubslow commented Jun 14, 2018

Closed by #80, I believe.

@dubslow dubslow closed this as completed Jun 14, 2018
Promoting lc0 to main pipeline automation moved this from In progress to Done Jun 14, 2018
jjoshua2 added a commit to MelleKoning/lc0 that referenced this issue Apr 20, 2019
@jjoshua2
Merge pull request LeelaChessZero#20 from MelleKoning/print-fen
1023f47 
Print fen
borg323 pushed a commit to borg323/lc0 that referenced this issue Jan 14, 2020
@ankan-ban
Merge pull request LeelaChessZero#20 from borg323/dx
5ac2192 
build shaders with meson
cn4750 pushed a commit to cn4750/lc0 that referenced this issue Oct 19, 2020
@Naphthalin
Merge pull request LeelaChessZero#20 from LeelaChessZero/master
449df55 
Install Eigen library into the Docker image used by CircleCi (LeelaChessZero#1412)
Tilps added a commit that referenced this issue Apr 1, 2022
@Tilps @borg323
Attention blas (No policy encoder block support) (#1709)
bcd6762 
* Add mish support to blas backend.

* Silence a warning.

* Add support for policy attention head to blas.  No Encoder support.

* loop unswitching and some updates (#20)

* loop unswitching and some updates

* add missing changest

* restore mish accuracy

* refactor

Co-authored-by: borg323 <borg323@users.noreply.github.com>

Co-authored-by: borg323 <39573933+borg323@users.noreply.github.com>
Co-authored-by: borg323 <borg323@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Promoting lc0 to main pipeline
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@killerducky @dubslow @mooskagh @gonzalezjo