Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuración de test dentro de modulo no muestra preguntas la primera vez #502

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

fermarinsanchez
Copy link
Contributor

fix(tests): on manual config, fix relationship between question tabs on first render

Copy link
Contributor

@johan-fx johan-fx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take a look at the suggestions

@@ -77,6 +88,7 @@ const ManualQuestionsGenerator = ({
render={({ field }) => (
<QuestionsTable
questions={manualQuestions}
listadoSeleccionadas={true}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use plain English when declaring variables or props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listadoSeleccionadas is an useless property. I proceed to remove it.

Copy link

sonarcloud bot commented Jul 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Contributor

@johan-fx johan-fx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! every looks good now

@johan-fx johan-fx merged commit 87c0854 into dev Jul 8, 2024
2 of 3 checks passed
@johan-fx johan-fx deleted the issue/Transversal-246 branch July 8, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants