-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuración de test dentro de modulo no muestra preguntas la primera vez #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please take a look at the suggestions
@@ -77,6 +88,7 @@ const ManualQuestionsGenerator = ({ | |||
render={({ field }) => ( | |||
<QuestionsTable | |||
questions={manualQuestions} | |||
listadoSeleccionadas={true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use plain English when declaring variables or props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listadoSeleccionadas is an useless property. I proceed to remove it.
plugins/leemons-plugin-tests/frontend/src/pages/private/tests/components/QuestionsTable.js
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect! every looks good now
fix(tests): on manual config, fix relationship between question tabs on first render